CCIP - Version based changesets #16504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnieeG
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
bukata-sa
previously approved these changes
Feb 21, 2025
makramkd
reviewed
Feb 21, 2025
Comment on lines
21
to
22
| "github.com/smartcontractkit/chainlink/deployment/ccip/changeset" | ||
| cs "github.com/smartcontractkit/chainlink/deployment/ccip/changeset" |
There was a problem hiding this comment.
Shouldn't we put the solana directory under v1_6? Or only after their contracts are frozen?
There was a problem hiding this comment.
Can discuss with solana team and create a new PR for that
| @@ -49,7 +50,7 @@ type TestConfigs struct { | |||
| // TODO: This should be CreateContracts so the booleans make sense? | |||
| CreateJobAndContracts bool | |||
| PrerequisiteDeploymentOnly bool | |||
| V1_5Cfg changeset.V1_5DeploymentConfig | |||
| V1_5Cfg v1_6.V1_5DeploymentConfig | |||
There was a problem hiding this comment.
Kinda odd to have V1_5DeploymentConfig in the v1_6 package no?
There was a problem hiding this comment.
oh right. good catch. I should move this changeset DeployPrerequisite to common. It deploys a mix of all 1.2, 1.5, 1.6
|
makramkd
approved these changes
Feb 21, 2025
b-gopalswami
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that each versioned folders use specific versioned contracts