Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DestGasOverhead from CalculateMessageMaxGasWithError #16501

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

asoliman92
Copy link
Contributor

This was wrongly added as we already have enough overhead added from other fields which made the estimation very high

This was wrongly added as we already have enough overhead added from other fields which made the estimation very high
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@asoliman92 asoliman92 force-pushed the remove-wrong-gasoverhead branch from 90351e8 to b166ea4 Compare February 20, 2025 18:10
RensR
RensR previously approved these changes Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 55cee3f (remove-wrong-gasoverhead).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

4 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestCalculateMaxGas 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccipevm false 0s @smartcontractkit/ccip-offchain
TestCalculateMaxGas/maxGasOverheadGas_1 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccipevm false 0s @smartcontractkit/ccip-offchain
TestCalculateMaxGas/maxGasOverheadGas_2 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccipevm false 0s @smartcontractkit/ccip-offchain
TestCalculateMaxGas/v2_extra_args 0% false false false 3 0 3 0 github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccipevm false 0s @smartcontractkit/ccip-offchain

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

RensR
RensR previously approved these changes Feb 21, 2025
@asoliman92 asoliman92 enabled auto-merge February 21, 2025 11:23
@asoliman92 asoliman92 added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit 944f84d Feb 21, 2025
179 of 180 checks passed
@asoliman92 asoliman92 deleted the remove-wrong-gasoverhead branch February 21, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants