Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reusable workflow without log spamming #16499

Merged
merged 5 commits into from
Feb 24, 2025
Merged

reusable workflow without log spamming #16499

merged 5 commits into from
Feb 24, 2025

Conversation

Tofel
Copy link
Contributor

@Tofel Tofel commented Feb 20, 2025 •
edited
Loading

do not print Docker container logs, when test fails.

What we want to achieve is this:

Run jwalton/gh-docker-logs@2741064ab9d7af54b0b1ffb6076cf64c16f0220e
Found 11 containers...
Found 0 matching containers...

Instead of what we currently have:

Run jwalton/gh-docker-logs@2741064ab9d7af54b0b1ffb6076cf64c16f0220e
Found 12 containers...


***.dkr.ecr.***.amazonaws.com/chainlink:10ed0f95f98f03aa058b66cf05fc63aa3c418cc0-plugins (workflow-node1)
***.dkr.ecr.***.amazonaws.com/chainlink:10ed0f95f98f03aa058b66cf05fc63aa3c418cc0-plugins (workflow-node3)
***.dkr.ecr.***.amazonaws.com/chainlink:10ed0f95f98f03aa058b66cf05fc63aa3c418cc0-plugins (workflow-node4)
***.dkr.ecr.***.amazonaws.com/chainlink:10ed0f95f98f03aa058b66cf05fc63aa3c418cc0-plugins (workflow-node2)
***.dkr.ecr.***.amazonaws.com/chainlink:10ed0f95f98f03aa058b66cf05fc63aa3c418cc0-plugins (workflow-node0)
postgres:12.0 (workflow-ns-postgresql)
gaiaadm/pumba (chaos-e1012)
***.dkr.ecr.***.amazonaws.com/job-distributor:0.6.0 (jd-5dc23)
postgres:12 (jd-db)
f4hrenh9it/foundry:latest (blockchain-node-a858b)
testcontainers/ryuk:0.11.0 (reaper_4464d94da0acc500833dcb3bc93062922a0c9fcf4df6d0206f8952c2c56a56ad)
envoyproxy/envoy:v1.33.0 (gap)

As that resulted in printing logs of all these tests to the CI.

@Tofel Tofel requested review from a team as code owners February 20, 2025 15:59
@Tofel Tofel requested a review from vyzaldysanchez February 20, 2025 15:59
@Tofel Tofel changed the title try new reusable workflow [DO NOT REVIEW] reusable workflow without log spamming [DO NOT REVIEW] Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@Tofel Tofel force-pushed the do-not-print-docker-logs branch 2 times, most recently from 77d9389 to 89e160e Compare February 20, 2025 16:57
@Tofel Tofel force-pushed the do-not-print-docker-logs branch from 89e160e to d33ddfc Compare February 20, 2025 17:53
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@Tofel Tofel changed the title reusable workflow without log spamming [DO NOT REVIEW] reusable workflow without log spamming Feb 24, 2025
@Tofel Tofel enabled auto-merge February 24, 2025 11:25
@Tofel Tofel added this pull request to the merge queue Feb 24, 2025
Merged via the queue into develop with commit 25bc303 Feb 24, 2025
180 checks passed
@Tofel Tofel deleted the do-not-print-docker-logs branch February 24, 2025 11:54
krehermann pushed a commit that referenced this pull request Feb 27, 2025
@Tofel @krehermann
reusable workflow without log spamming (#16499)
7f9c8a4 
* try new reusable workflow

* remove on-purpose failure

* use e2e reusable workflow commit from main .github branch

* do not use GAP with Docker tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skudasov skudasov skudasov approved these changes

@gheorghestrimtu gheorghestrimtu gheorghestrimtu approved these changes

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez vyzaldysanchez was automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tofel @skudasov @gheorghestrimtu