[CCIP-5117] integration-tests/smoke/ccip: factor out fee test helpers #16496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
commented
Feb 21, 2025
| @@ -21,7 +21,7 @@ runner-test-matrix: | |||
| runs_on: ubuntu-latest | |||
| triggers: | |||
| - PR Integration CCIP Tests | |||
| test_cmd: cd integration-tests/smoke/ccip && go test ccip_fees_test.go -timeout 12m -test.parallel=2 -count=1 -json | |||
| test_cmd: cd integration-tests/smoke/ccip && go test ccip_fees_test.go -timeout 20m -test.parallel=2 -count=1 -json | |||
There was a problem hiding this comment.
This was taking really long on my PC but I think there's an issue w/ my PC. Anyway, doesn't hurt to bump, will revisit this once we drop round times significantly and make the tests faster.
| assertExecution bool | ||
| } | ||
|
|
||
| func RunFeeTokenTestCase(tc FeeTokenTestCase) { |
There was a problem hiding this comment.
Code is basically copy/paste of what was in ccip_fees_test.go, just made public and moved to deployment so we can use it in CLD
Comment on lines
-227
to
+224
| blockNum, err := e.Chains[cfg.SourceChain].Confirm(tx) | ||
| blockNum, err := deployment.ConfirmIfNoErrorWithABI(e.Chains[cfg.SourceChain], tx, router.RouterABI, err) |
There was a problem hiding this comment.
Prints out revert reason, useful
| src: sourceChain, | ||
| env: tenv, | ||
| tokenAmounts: []router.ClientEVMTokenAmount{ | ||
| feestest.RunFeeTokenTestCase(feestest.NewFeeTokenTestCase( |
There was a problem hiding this comment.
No real changes here, just uses the new API.
makramkd
requested review from
winder,
asoliman92,
dimkouv,
mateusz-sekara,
0xAustinWang,
0xnogo and
b-gopalswami
|
dimkouv
approved these changes
Feb 21, 2025
mateusz-sekara
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out the CCIP fees test cases and runners into a separate package so we can run the same test cases from CLD.
Requires
N/A
Supports
N/A