fix(deployment): add labels to the MCMSWithTimelockConfigV2 type #16487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
gustavogama-cll
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
| require.NoError(t, err) | ||
| b, err := json.MarshalIndent(v, "", " ") | ||
| require.NoError(t, err) | ||
| t.Log(string(b)) |
There was a problem hiding this comment.
Just checking we do want to log the result ? Or should be assert it with a JSON result?
There was a problem hiding this comment.
🤷♂️ good question. I kinda copy&pasted the test...
graham-chainlink
approved these changes
Feb 20, 2025
eutopian
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed the addition of the "Label" field to the MCMSWithTimelockConfig type while working on the mcms migration. This PR adds the field to the new V2 type.