feat: add example changeset to transfer from timelock signer account #16476
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
ecPablo
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
deployment/common/changeset/example/solana_transfer_mcm_test.go
Outdated
Show resolved
Hide resolved
|
|
||
| config := proposalutils.SingleGroupTimelockConfigV2(t) | ||
| testhelpers.SavePreloadedSolAddresses(t, env, chainSelector) | ||
| // Initialize the address book with a dummy address to avoid deploy precondition errors. |
There was a problem hiding this comment.
I'm not 100% sure it's the same error I had, but if it is, I think we should avoid it by incorporating this change.
There was a problem hiding this comment.
Ah yes it's the same error, I'll keep it here in the meantime while we merge your PR. Just re approved!
deployment/common/changeset/example/solana_transfer_mcm_test.go
Outdated
Show resolved
Hide resolved
deployment/common/changeset/example/solana_transfer_mcm_test.go
Outdated
Show resolved
Hide resolved
deployment/common/changeset/example/solana_transfer_mcm_test.go
Outdated
Show resolved
Hide resolved
Not really, this example will be used more in the context of using the chainlink deployments framework so a user can have a instructions to sign and then call set root / execute via CLD and then easily check their balance to confirm the fund arrived to their account. It's more for "didactic" purposes |
I see, thanks for the context. I'll just throw my $0.02c -- just fyi, no action needed. I find that the external_program_cpi_stub program is great for this type of didactic test/example. I was able to experiment and validate quite a bit of logic in the mcms e2e tests thanks to its API, that is tailored for automated tests. |
Thanks Gustavo, yeah I did check on that program, I ended up doing this because using the stub program would mean adding another changeset for deploying it and another migration on the tutorial, making it a bit longer. |
You don't actually need to worry about deploying it. The cpi stub program is predeployed by CTF. Anyways, just something to consider next time. |
|
…16476) * feat: add changeset to transfer from timelock signer account * fix: linting errors * fix: code cleanup * fix: use NewTransactionFromInstruction * fix: cleanup accounts signer set
Adds an example changeset to be used on example guides that will transfer some fund from the timelock signer to the provided account via mcms.
AI Summary
This pull request introduces a new changeset for transferring funds from a timelock signer PDA to a specified address within the Solana blockchain environment. It includes the implementation of the changeset and its corresponding tests, as well as modifications to existing helper functions to support the new functionality.
New Changeset Implementation:
deployment/common/changeset/example/solana_transfer_mcm.go: Added theTransferFromTimelockchangeset which includes methods to verify preconditions and apply the changeset to transfer funds from the timelock signer PDA to the specified address.Testing:
deployment/common/changeset/example/solana_transfer_mcm_test.go: Added comprehensive tests for theTransferFromTimelockchangeset, including setup for the testing environment and validation of preconditions and application of the changeset.Helper Function Modifications:
deployment/common/changeset/solana/helpers.go: Modified theFundFromDeployerKeyfunction to use a new helper functionFundFromAddressIxswhich creates transfer instructions from a specified address. This change supports the new changeset by enabling fund transfers from the timelock signer PDA.