Feat/filter labeled addresses #16464
Merged
+676
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
MStreet3
force-pushed
the
feat/filter-labeled-addresses
branch
from
9232a0c to
0aa5162
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
MStreet3
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
MStreet3
commented
Feb 18, 2025
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
AnieeG
reviewed
Feb 18, 2025
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌4 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Removes check that the addresses contains all the types and versions defined in a bundle. It is not required that the MCMS state contracts be non-nil. There is a Validate() method and the docstring states that nil values are possible.
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌6 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
MStreet3
force-pushed
the
feat/filter-labeled-addresses
branch
from
6c63ae9 to
4cc29c1
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌6 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
MStreet3
force-pushed
the
feat/filter-labeled-addresses
branch
from
4cc29c1 to
b607296
Compare
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
AnieeG
previously approved these changes
Feb 19, 2025
eutopian
reviewed
Feb 19, 2025
| // EnsureDeduped ensures that each contract in the bundle only appears once | ||
| // in the address map. It returns an error if there are more than one instance of a contract. | ||
| // Returns true if every value in the bundle is found once, false otherwise. | ||
| func EnsureDeduped(addrs map[string]TypeAndVersion, bundle []TypeAndVersion) (bool, error) { |
eutopian
previously approved these changes
Feb 19, 2025
AnieeG
previously approved these changes
Feb 19, 2025
cedric-cordenier
previously approved these changes
Feb 20, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
MStreet3
dismissed stale reviews from cedric-cordenier and AnieeG
via
0320343
eutopian
approved these changes
Feb 20, 2025
cedric-cordenier
approved these changes
Feb 20, 2025
|
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16148 added labels to contract addresses on deployment, but did not introduce filtering. This introduced a bug where certain changesets in
chainlink-deploymentsthat relied on the assumption of a single contract per chain for MCMS contracts inadvertently generated proposals with the wrong MCMS contract addresses.This PR fixes the issue by filtering contracts by labels when loading the address book in a backwards compatible way. If the passed label set is empty, then only un-labeled contracts are returned. If there are labels passed in the request, then only contracts that have all labels are returned.
Requires
Supports