Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom deviation function for pendle #16462

Closed
wants to merge 1 commit into from

Conversation

samsondav
Copy link
Collaborator

No description provided.

@samsondav samsondav added build-test-image Will build the e2e test image in integration-tests workflow for PRs build-publish Build and Publish image to SDLC labels Feb 18, 2025
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Does NOT include any integration tests. Experimental alpha.
@samsondav samsondav force-pushed the 2.21.0-pendle-deviation branch from 6a171da to 2d15e77 Compare February 19, 2025 14:42
@cl-sonarqube-production
Copy link

Copy link
Contributor

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , test-scripts , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , GolangCI Lint (core/scripts) , Core Tests (go_core_fuzz) , GolangCI Lint (.) , Core Tests (go_core_race_tests) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , lint , SonarQube Scan

1. Unsupported protocol error during crate download: [Build Solana artifacts]

Source of Error:
Build Solana artifacts 2025-02-19T14:49:23.5128737Z #8 206.4 error: failed to download from `https://static.crates.io/crates/uint/0.9.5/download`
Build Solana artifacts 2025-02-19T14:49:23.5129421Z #8 206.4 
Build Solana artifacts 2025-02-19T14:49:23.5129720Z #8 206.4 Caused by:
Build Solana artifacts 2025-02-19T14:49:23.5130315Z #8 206.4 [1] Unsupported protocol (Received HTTP/0.9 when not allowed)

Why: The error indicates that the download attempt for the crate uint failed due to an unsupported protocol, specifically HTTP/0.9, which is not allowed.

Suggested fix: Ensure that the URL used for downloading the crate supports the required protocol (HTTP/1.1 or higher). Check network configurations or proxy settings that might be downgrading the protocol.

2. Plugin compilation error: [Install LOOP Plugins]

Source of Error:
Install LOOP Plugins 2025-02-19T14:45:42.9644486Z ##[error]cmd/chainlink-feeds/main.go:31:19: cannot use p (variable of type *"github.com/smartcontractkit/chainlink-feeds/median".Plugin) as core.PluginMedian value in struct literal: *"github.com/smartcontractkit/chainlink-feeds/median".Plugin does not implement core.PluginMedian (wrong type for method NewMedianFactory)
Install LOOP Plugins 2025-02-19T14:45:42.9655400Z have NewMedianFactory(context.Context, "github.com/smartcontractkit/chainlink-common/pkg/types".MedianProvider, string, "github.com/smartcontractkit/libocr/offchainreporting2/reportingplugin/median".DataSource, "github.com/smartcontractkit/libocr/offchainreporting2/reportingplugin/median".DataSource, "github.com/smartcontractkit/libocr/offchainreporting2/reportingplugin/median".DataSource, core.ErrorLog, ..."github.com/smartcontractkit/chainlink-feeds/median".Option) ("github.com/smartcontractkit/chainlink-common/pkg/types".ReportingPluginFactory, error)
Install LOOP Plugins 2025-02-19T14:45:42.9659837Z want NewMedianFactory(context.Context, "github.com/smartcontractkit/chainlink-common/pkg/types".MedianProvider, string, "github.com/smartcontractkit/libocr/offchainreporting2/reportingplugin/median".DataSource, "github.com/smartcontractkit/libocr/offchainreporting2/reportingplugin/median".DataSource, "github.com/smartcontractkit/libocr/offchainreporting2/reportingplugin/median".DataSource, core.ErrorLog) ("github.com/smartcontractkit/chainlink-common/pkg/types".ReportingPluginFactory, error)

Why: The Plugin type from chainlink-feeds/median does not implement the core.PluginMedian interface correctly due to a mismatch in the NewMedianFactory method signature.

Suggested fix: Update the Plugin type in chainlink-feeds/median to match the expected method signature of NewMedianFactory as defined in core.PluginMedian.

3. Type mismatch error in test: [Run Tests]

Source of Error:
Run Tests 2025-02-19T14:44:18.4557852Z ##[error]../capabilities/ccip/ccipsolana/commitcodec.go:72:15: cannot use mr (variable of type ccip_offramp.MerkleRoot) as *ccip_offramp.MerkleRoot value in struct literal

Why: The variable mr of type ccip_offramp.MerkleRoot is being used where a pointer to ccip_offramp.MerkleRoot is expected.

Suggested fix: Change the usage of mr to a pointer type by using &mr if mr is already a value type, or ensure mr is declared as a pointer type.

4. Multiple-value context error in test: [Golang Lint (.)]

Source of Error:
Golang Lint (.) 2025-02-19T14:48:06.0232974Z ##[error]core/services/ocr2/plugins/median/config/deviation_test.go:42:19: multiple-value f(nil, 1e7, big.NewInt(0.187152977881070687 CHANGELOG.md GNUmakefile LICENSE README.md SECURITY.md ccip common config_docs_test.go contracts core dashboard-lib deployment docs error_reporter_actions flake.lock flake.nix fuzz go.md go.mod go.sum integration-tests internal main.go main_integration_test.go main_test.go nix-darwin-shell-hook.sh nix.conf operator_ui package.json plugins pnpm-lock.yaml rawlog.log runlog.log shell.nix sonar-project.properties testdata tools 1e18), big.NewInt(0.160000000000000000 CHANGELOG.md GNUmakefile LICENSE README.md SECURITY.md ccip common config_docs_test.go contracts core dashboard-lib deployment docs error_reporter_actions flake.lock flake.nix fuzz go.md go.mod go.sum integration-tests internal main.go main_integration_test.go main_test.go nix-darwin-shell-hook.sh nix.conf operator_ui package.json plugins pnpm-lock.yaml rawlog.log runlog.log shell.nix sonar-project.properties testdata tools 1e18)) (value of type (bool, error)) in single-value context

Why: The function f returns multiple values, but it is being used in a context where only a single value is expected.

Suggested fix: Adjust the context to handle multiple return values from f, or modify the function call to use only the required value.

5. Undefined variable error in test: [Golang Lint (.)]

Source of Error:
Golang Lint (.) 2025-02-19T14:48:06.0238936Z ##[error]core/services/ocr2/plugins/median/config/deviation_test.go:47:115: undefined: expiresAt (typecheck)

Why: The variable expiresAt is used but not defined within the scope of the test.

Suggested fix: Define the variable expiresAt within the scope of the test or ensure it is imported from the correct package if it is defined elsewhere.

@samsondav samsondav closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-publish Build and Publish image to SDLC build-test-image Will build the e2e test image in integration-tests workflow for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant