chore(deployment): migrate CCIP changesets to the new MCMS lib #16458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌2 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
This was referenced Feb 18, 2025
gustavogama-cll
changed the title
gustavogama-cll
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌22 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
ecPablo
previously approved these changes
Feb 18, 2025
gustavogama-cll
force-pushed
the
ggama/chore-migrate-ccip-changesets-to-new-mcms-lib
branch
from
a0df319 to
6a03ea4
Compare
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌2 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌23 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
gustavogama-cll
force-pushed
the
ggama/chore-migrate-ccip-changesets-to-new-mcms-lib
branch
from
6a03ea4 to
b877845
Compare
|
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
ecPablo
approved these changes
Feb 19, 2025
|
@AnieeG , could you take a look at this when you get a chance? |
|
@graham-chainlink , could you take a look at this one more time, please? I've addressed the issue you raised last time. |
graham-chainlink
approved these changes
Feb 20, 2025
gustavogama-cll
deleted the
ggama/chore-migrate-ccip-changesets-to-new-mcms-lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate CCIP changesets to the new MCMS library. In practice, this simply means using the
V2helpers in theproposalutilspackage, instead of the original ones.The PR also includes a small fix to the
ExecuteTimelockProposalhelper, which was not using the call proxy contract for EVM calls.