Parallelize ccip crib deployer #16451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
asoliman92
requested review from
winder,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang,
0xnogo and
b-gopalswami
| OnRampUpdates: make(map[uint64]bool), | ||
| } | ||
| rateLimitPerChain := make(changeset.RateLimiterPerChain) | ||
| eg.Go(func() error { |
There was a problem hiding this comment.
we need to shadow src variable here
|
makramkd
approved these changes
Feb 19, 2025
Comment on lines
+162
to
+164
| deployGrp := errgroup.Group{} | ||
|
|
||
| _, err := deployTokenPool(env.Logger, chain, chainState, newAddresses, poolConfig, c.IsTestRouter) | ||
| if err != nil { | ||
| return deployment.ChangesetOutput{}, fmt.Errorf("failed to deploy %s token pool on %s: %w", c.TokenSymbol, chain.String(), err) | ||
| } | ||
| for chainSelector, poolConfig := range c.NewPools { |
There was a problem hiding this comment.
@AnieeG @kylesmartin is this supposed to be idempotent? It wasn't before, so I think this is effectively a no-op, but just wanted to flag in-case.
0xAustinWang
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.