[DPA-1476]: fix(mcms): update keystones changesets to new MCMS #16443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graham-chainlink
force-pushed
the
ggoh/DPA-1476/migrate-keystones-changesets
branch
from
f9b9c40 to
429a021
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
graham-chainlink
force-pushed
the
ggoh/DPA-1476/migrate-keystones-changesets
branch
2 times, most recently
from
3c8d951 to
cb6ec96
Compare
graham-chainlink
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
graham-chainlink
force-pushed
the
ggoh/DPA-1476/migrate-keystones-changesets
branch
from
cb6ec96 to
36eb603
Compare
graham-chainlink
force-pushed
the
ggoh/DPA-1476/migrate-keystones-changesets
branch
from
36eb603 to
de3e5f5
Compare
Update the existing keystone changesets to use the [new MCMS library](https://github.com/smartcontractkit/mcms) types. We want to eventually remove the legacy MCMS type. **Do not be alarm by the amount of file changes, all the changes are kind of the same** - Update type `timelock.BatchChainOperation` -> `mcmstypes.BatchOperation` - use `out.MCMSTimelockProposals` instead of `out.Proposals` - Update type `Batch` -> `Transactions` There will be breaking changes on the CLD side due to the types being change, i have an [accompany PR](smartcontractkit/chainlink-deployments#774) for that so it goes in together. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1476
graham-chainlink
force-pushed
the
ggoh/DPA-1476/migrate-keystones-changesets
branch
from
de3e5f5 to
0dda624
Compare
gustavogama-cll
approved these changes
Feb 19, 2025
|
ecPablo
approved these changes
Feb 19, 2025
graham-chainlink
deleted the
ggoh/DPA-1476/migrate-keystones-changesets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the existing keystone changesets to use the new MCMS library types. We want to eventually remove the legacy MCMS type.
Do not be alarm by the amount of file changes, all the changes are kind of the same
timelock.BatchChainOperation->mcmstypes.BatchOperationout.MCMSTimelockProposalsinstead ofout.ProposalsBatch->TransactionsThere will be breaking changes on the CLD side due to the types being change, i have an accompany PR for that so it goes in together.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1476