Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CCIP specific files in contracts/ directory for v1.6.0 along with cherry pick fixes #16392

Merged
merged 21 commits into from
Feb 25, 2025
Merged

Replace CCIP specific files in contracts/ directory for v1.6.0 along with cherry pick fixes #16392

merged 21 commits into from
Feb 25, 2025

Conversation

chainchad
Copy link
Collaborator

Signed-off-by: chainchad [email protected]

@chainchad chainchad requested review from a team as code owners February 13, 2025 17:15
@chainchad chainchad requested review from krehermann and removed request for a team February 13, 2025 17:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@chainchad chainchad requested review from a team as code owners February 13, 2025 17:57
@chainchad
Revert "Install foundry in jobs"
9c345f3 
This reverts commit cfa1602.
@chainchad
Install foundry in solidity publish jobs (#16394)
521f49e 
* Install foundry in jobs

(cherry picked from commit cfa1602)

* Fix paths and cwd

(cherry picked from commit 571f72f)
@chainchad
Install foundry in prepublish test job for solidity and add other mis…
f47c5de 
…c contracts CI fixes (#16416)

* Install foundry in prepublish test job for solidity

* WIP: Temporarily run: pnpm copy:ccip-files

* Install additional dev deps

* Revert "WIP: Temporarily run: pnpm copy:ccip-files"

This reverts commit 098d073.

* CI fixes for CCIP Contracts (#16434)

* Install additional dev deps

* Copy over lockfile

* Simplify script command for copying ccip release files

(cherry picked from commit 5b5f2a1)

* Run pnpm install

(cherry picked from commit 91ce4c9)
@chainchad
CI fixes for CCIP Contracts (#16434)
62d9f2e 
* Install additional dev deps

* Copy over lockfile

* Simplify script command for copying ccip release files

(cherry picked from commit 5b5f2a1)
@chainchad chainchad requested a review from a team as a code owner February 21, 2025 20:41
@chainchad chainchad force-pushed the chore/release/contracts-ccip-1.6.0-file-copy branch from b01499f to ed8ea88 Compare February 21, 2025 21:45
chainchad and others added 3 commits February 21, 2025 16:54
@chainchad
Add solhint scripts for CI
8f5ab0f
@RensR
add oz dep
227cdd0
@RensR
Bump npm deps and Foundry (#16293)
a936cea 
* bump foundry

* bump npm deps

* bump solhint

* changeset

* add default.allow_internal_expect_revert
@RensR RensR requested review from a team as code owners February 24, 2025 08:12
@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

Solidity Review Jira issue

Hey! We have taken the liberty to link this PR to a Jira issue for Solidity Review.

This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one.
Please reach out to the Test Tooling team and notify them about any issues you encounter.

Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: contracts/.changeset/eight-starfishes-own.md

This PR has been linked to Solidity Review Jira issue: CCIP-3966

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 24, 2025 •
edited
Loading

Static analysis results are available

Hey @chainchad, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@RensR @chainchad
Bump npm deps and Foundry (#16293)
fa3fabc 
* bump foundry

* bump npm deps

* bump solhint

* changeset

* add default.allow_internal_expect_revert

(cherry picked from commit fba3796)
@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@chainchad chainchad changed the title Replace CCIP specific files in contracts/ directory for v1.6.0 and run pnpm i Replace CCIP specific files in contracts/ directory for v1.6.0 along with cherry pick fixes Feb 24, 2025
RensR
RensR previously approved these changes Feb 24, 2025
View reviewed changes
kalverra
kalverra previously approved these changes Feb 25, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@github-actions GitHub Actions
Copy link
Contributor

It appears that the changeset file you've added or modified in contracts/.changeset is not valid.
Please delete the file and run pnpm changeset in the contracts directory.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@chainchad chainchad merged commit 82ab04f into release/contracts-ccip-1.6.0 Feb 25, 2025
156 of 162 checks passed
@chainchad chainchad deleted the chore/release/contracts-ccip-1.6.0-file-copy branch February 25, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR approved these changes

@kalverra kalverra kalverra approved these changes

@DimitriosNaikopoulos DimitriosNaikopoulos DimitriosNaikopoulos approved these changes

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chainchad @RensR @kalverra @DimitriosNaikopoulos