Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend job delete DB timeout to 10 minutes #15211

Closed
wants to merge 1 commit into from
Closed

Extend job delete DB timeout to 10 minutes #15211

wants to merge 1 commit into from

Conversation

bolekk
Copy link
Contributor

@bolekk bolekk commented Nov 12, 2024

No description provided.

@bolekk bolekk added the build-publish Build and Publish image to SDLC label Nov 12, 2024
@bolekk bolekk requested review from a team as code owners November 12, 2024 18:51
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

Copy link
Contributor

github-actions bot commented Nov 12, 2024

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , Find New Flaky Tests In Root Project / Find Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Find New Flaky Tests In Deployment Project , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Root Project / Run Tests , Find New Flaky Tests In Root Project / Report , Flakey Test Detection , SonarQube Scan

1. Declaration of "ctx" shadows declaration at line 712:[Golang Lint]

Source of Error:
core/services/job/orm.go:716:3: shadow: declaration of "ctx" shadows declaration at line 712 (govet)
	ctx, cancel := context.WithTimeout(sqlutil.WithoutDefaultTimeout(ctx), 10*time.Minute)
	^
**Why**: This error occurs because the variable `ctx` is redeclared within the same scope, which shadows the previous declaration of `ctx` at line 712. This can lead to confusion and potential bugs as the inner `ctx` will be used instead of the outer one.

Suggested fix: Rename the inner ctx variable to a different name to avoid shadowing the outer ctx variable.

2. Encountered test failures:[Run tests]

Source of Error:
Run tests	2024-11-12T22:45:01.4593516Z Encountered test failures.
Run tests	2024-11-12T22:45:01.4594062Z go_core_tests exiting with code 1
Run tests	2024-11-12T22:45:01.4610985Z ##[error]Process completed with exit code 1.
**Why**: The test suite encountered one or more test failures, which caused the `go_core_tests` job to exit with a non-zero status code.

Suggested fix: Review the test output logs to identify the specific tests that failed. Investigate the root cause of the failures and fix the underlying issues in the code or the tests themselves.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

ilija42
ilija42 previously approved these changes Nov 12, 2024
jmank88
jmank88 previously approved these changes Nov 12, 2024
@bolekk
Copy link
Contributor Author

bolekk commented Nov 12, 2024

Even 10 mins doesn't cut it on some nodes :/ Adding some ugly hackery to test it out. Do not merge please.

@bolekk bolekk requested a review from a team as a code owner November 12, 2024 23:26
@bolekk
Copy link
Contributor Author

bolekk commented Nov 12, 2024

this is hopeless

@bolekk bolekk closed this Nov 12, 2024
auto-merge was automatically disabled November 12, 2024 23:39

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-publish Build and Publish image to SDLC DO_NOT_MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants