Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Solana TXM in-memory storage to track transactions by statuses #15104

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Updated Solana TXM in-memory storage to track transactions by statuses #15104

merged 8 commits into from
Nov 13, 2024

Conversation

amit-momin
Copy link
Contributor

NONEVM-708

  • Updated Solana TXM's in-memory storage to track statuses across the Solana transaction lifecycle
  • Added a method to translate Solana transaction statuses into states expected by the ChainWriter interface
  • Made the duration transactions are retained in storage after finality or error configurable using TxRetentionTimeout

Requires

smartcontractkit/chainlink-solana#909

@amit-momin amit-momin requested review from a team as code owners November 4, 2024 20:04
@amit-momin amit-momin requested a review from krehermann November 4, 2024 20:04
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Flaky Test Detector for ./go.mod project has failed ❌

Ran new or updated tests between develop and 8d3c593 (feature/in-memory-storage-upgrade-solana-txm).

View Flaky Detector Details | Compare Changes

Failed Tests

Ran 364 tests in total for all affected test packages. Below are the tests identified as flaky, with a pass ratio lower than the 100% threshold:

TestPackage                                                       TestName                                         PassRatio  RunCount   Skipped
---------                                                         ---------                                        ---------  ---------  ---------
github.com/smartcontractkit/chainlink/v2/core/web                 Test_SolanaChainsController_Show/success         0%         1          false
github.com/smartcontractkit/chainlink/v2/core/web                 Test_SolanaChainsController_Show                 0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/multi-chain  0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration/full         0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  Test_generalConfig_LogConfiguration              0%         1          false
github.com/smartcontractkit/chainlink/v2/core/services/chainlink  TestConfig_full                                  0%         1          false

silaslenihan
silaslenihan previously approved these changes Nov 8, 2024
View reviewed changes
Farber98
Farber98 previously approved these changes Nov 8, 2024
View reviewed changes
@amit-momin amit-momin dismissed stale reviews from Farber98 and silaslenihan via 49d536b November 12, 2024 21:59
@amit-momin amit-momin mentioned this pull request Nov 13, 2024
Merged
@reductionista reductionista added this pull request to the merge queue Nov 13, 2024
Merged via the queue into develop with commit cf7db16 Nov 13, 2024
141 of 142 checks passed
@reductionista reductionista deleted the feature/in-memory-storage-upgrade-solana-txm branch November 13, 2024 17:57
This was referenced Nov 13, 2024
Draft
Draft
This was referenced Nov 16, 2024
Draft
Draft
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Draft
@github-actions github-actions bot mentioned this pull request Dec 18, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reductionista reductionista reductionista approved these changes

@silaslenihan silaslenihan silaslenihan approved these changes

@Farber98 Farber98 Farber98 approved these changes

@krehermann krehermann Awaiting requested review from krehermann krehermann is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amit-momin @reductionista @silaslenihan @Farber98