Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCFR-967 - EVM Chain bindings for CR/CW - Basic support for method #14657

Merged
merged 9 commits into from
Nov 12, 2024
Merged

BCFR-967 - EVM Chain bindings for CR/CW - Basic support for method #14657

merged 9 commits into from
Nov 12, 2024

Conversation

pablolagreca
Copy link
Collaborator

@pablolagreca pablolagreca commented Oct 3, 2024 •
edited by jira bot
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

WF: CI Core#b52969b

No errors found in this run. 🎉

@pablolagreca pablolagreca force-pushed the BCFR-967 branch 2 times, most recently from 2135575 to b52969b Compare October 15, 2024 11:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

WF: CI Core#9b1db39

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

WF: CI Core#5aec27f

No errors found in this run. 🎉

@pablolagreca pablolagreca force-pushed the BCFR-967 branch 2 times, most recently from 5aec27f to 1930aee Compare October 15, 2024 14:10
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
3 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
95.6% Coverage on New Code
6.7% Duplication on New Code

See analysis details on SonarQube

@pablolagreca pablolagreca marked this pull request as ready for review October 30, 2024 21:17
@pablolagreca pablolagreca requested review from a team as code owners October 30, 2024 21:17
@pablolagreca pablolagreca requested a review from Atrax1 October 30, 2024 21:17
ilija42
ilija42 previously approved these changes Oct 31, 2024
View reviewed changes
jmank88
jmank88 reviewed Nov 4, 2024
View reviewed changes
core/services/relay/evm/evmtesting/run_tests.go Outdated
Comment on lines 25 to 32
QueryKeyFilterOnDataWordsWithValueComparator = "Filtering can be done on data words using value comparator"
QueryKeyOnDataWordsWithValueComparatorOnNestedField = "Filtering can be done on data words using value comparator on a nested field"
QueryKeyFilterOnDataWordsWithValueComparatorOnDynamicField = "Filtering can be done on data words using value comparator on field that follows a dynamic field"
QueryKeyFilteringOnDataWordsUsingValueComparatorsOnFieldsWithManualIndex = "Filtering can be done on data words using value comparators on fields that require manual index input"
DynamicTypedTopicsFilterAndCorrectReturn = "Dynamically typed topics can be used to filter and have type correct in return"
MultipleTopicCanFilterTogether = "Multiple topics can filter together"
FilteringCanBeDoneOnHashedIndexedTopics = "Filtering can be done on indexed topics that get hashed"
BindReturnsErrorOnMissingContractAtAddress = "Bind returns error on missing contract at address"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This names are pretty hard to read. What is the advantage of using constants over inline literals?

@pablolagreca pablolagreca requested a review from jmank88 November 4, 2024 18:54
@pablolagreca pablolagreca force-pushed the BCFR-967 branch 3 times, most recently from 1b64f68 to 9340608 Compare November 6, 2024 20:30
@pablolagreca pablolagreca force-pushed the BCFR-967 branch 4 times, most recently from a7247cb to bb0b7e5 Compare November 11, 2024 14:15
EasterTheBunny
EasterTheBunny previously approved these changes Nov 11, 2024
View reviewed changes
ilija42
ilija42 previously approved these changes Nov 12, 2024
View reviewed changes
@pablolagreca pablolagreca dismissed stale reviews from ilija42 and EasterTheBunny via f261a21 November 12, 2024 14:57
@jmank88 jmank88 added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@jmank88 jmank88 added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@jmank88 jmank88 added this pull request to the merge queue Nov 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 12, 2024
@jmank88 jmank88 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into develop with commit 275cf37 Nov 12, 2024
138 of 142 checks passed
@jmank88 jmank88 deleted the BCFR-967 branch November 12, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@ilija42 ilija42 ilija42 approved these changes

@EasterTheBunny EasterTheBunny EasterTheBunny left review comments

@Atrax1 Atrax1 Awaiting requested review from Atrax1 Atrax1 is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablolagreca @jmank88 @EasterTheBunny @ilija42