Aptos (combined branch)

[archseer]

Contains #14076, #14078 and staged changes

[archseer]

Perhaps all this can be moved into InitAptos?

[bolekk]

I like having this merged as an example trigger. I only wish it could go to common but it can't because of EVM dep :( Maybe we should create a special sub-directory with example capabilities and move on-demand trigger there as well...? @cedric-cordenier thoughts?

[github-actions]

AER Report: CI Core

aer_workflow , commit , Detect Changes , Scheduled Run Frequency , Clean Go Tidy & Generate , Find New Flaky Tests In Chainlink Project / Get Tests To Run , lint , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , Find New Flaky Tests In Deployment Project , Find New Flaky Tests In Chainlink Project / Run Tests , Find New Flaky Tests In Chainlink Project / Report , Flakey Test Detection , SonarQube Scan

1. Integer overflow conversion int -> uint8: [Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:72:20: G115: integer overflow conversion int -> uint8 (gosec)
		bytes[31] = uint8(i + 1)
		 ^

**Why**: This error occurs because converting an `int` to `uint8` can result in an overflow if the `int` value exceeds the range of `uint8` (0 to 255).

Suggested fix: Ensure that the int value being converted to uint8 is within the valid range (0 to 255) before performing the conversion.

2. Integer overflow conversion int64 -> uint32: [Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:138:29: G115: integer overflow conversion int64 -> uint32 (gosec)
	Timestamp: uint32(timestamp),
	 ^
core/capabilities/streams/mock_trigger.go:139:29: G115: integer overflow conversion int64 -> uint32 (gosec)
	ValidFromTimestamp: uint32(timestamp),
	 ^
core/capabilities/streams/mock_trigger.go:144:29: G115: integer overflow conversion int64 -> uint32 (gosec)
	ExpiresAt: uint32(timestamp + 1000000),
	 ^

**Why**: This error occurs because converting an `int64` to `uint32` can result in an overflow if the `int64` value exceeds the range of `uint32` (0 to 4294967295).

Suggested fix: Ensure that the int64 value being converted to uint32 is within the valid range (0 to 4294967295) before performing the conversion.

3. Integer overflow conversion int -> uint32: [Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:181:94: G115: integer overflow conversion int -> uint32 (gosec)
	reportCtx := ocrTypes.ReportContext{ReportTimestamp: ocrTypes.ReportTimestamp{Epoch: uint32(baseTimestamp + j)}}
	 ^

**Why**: This error occurs because converting an `int` to `uint32` can result in an overflow if the `int` value exceeds the range of `uint32` (0 to 4294967295).

Suggested fix: Ensure that the int value being converted to uint32 is within the valid range (0 to 4294967295) before performing the conversion.

4. Receiver name inconsistency: [Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:110:1: receiver-naming: receiver name o should be consistent with previous receiver name m for MockTriggerService (revive)
func (o *MockTriggerService) RegisterTrigger(ctx context.Context, req capabilities.TriggerRegistrationRequest) (<-chan capabilities.TriggerResponse, error) {
	ch, err := o.MercuryTriggerService.RegisterTrigger(ctx, req)
	if err != nil {
		return nil, err
	}
	config, _ := o.MercuryTriggerService.ValidateConfig(req.Config)
	o.subscribersMu.Lock()
	defer o.subscribersMu.Unlock()
	o.subscribers[req.Metadata.WorkflowID] = config.FeedIds
	return ch, nil
}
core/capabilities/streams/mock_trigger.go:123:1: receiver-naming: receiver name o should be consistent with previous receiver name m for MockTriggerService (revive)
func (o *MockTriggerService) UnregisterTrigger(ctx context.Context, req capabilities.TriggerRegistrationRequest) error {
	err := o.MercuryTriggerService.UnregisterTrigger(ctx, req)
	o.subscribersMu.Lock()
	defer o.subscribersMu.Unlock()
	delete(o.subscribers, req.Metadata.WorkflowID)
	return err
}

**Why**: The receiver name `o` is inconsistent with the previous receiver name `m` for the `MockTriggerService` type, which can lead to confusion.

Suggested fix: Rename the receiver o to m to maintain consistency with the previous receiver name.

5. Unnecessary trailing newline: [Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:211:3: unnecessary trailing newline (whitespace)

**Why**: There is an unnecessary trailing newline in the code, which is flagged by the linter.

Suggested fix: Remove the unnecessary trailing newline to adhere to code style guidelines.

6. Replace prices[i] = prices[i] + 1 with prices[i]++: [Golang Lint]

Source of Error:

core/capabilities/streams/mock_trigger.go:173:4: assignOp: replace `prices[i] = prices[i] + 1` with `prices[i]++` (gocritic)
	prices[i] = prices[i] + 1
	^

**Why**: The linter suggests using the increment operator `++` instead of `prices[i] = prices[i] + 1` for better readability and conciseness.

Suggested fix: Replace prices[i] = prices[i] + 1 with prices[i]++.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
11.67% Technical Debt Ratio on New Code (required ≤ 4%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[github-actions]

I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

[github-actions]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.