From f928260d19fce0d3fc0b98a7aef3626ae09a60be Mon Sep 17 00:00:00 2001 From: patrickhuie19 Date: Tue, 18 Feb 2025 17:23:05 -0500 Subject: [PATCH] removing test in syncer relying on engine.Ready before Close --- .../services/workflows/syncer/handler_test.go | 58 ------------------- 1 file changed, 58 deletions(-) diff --git a/core/services/workflows/syncer/handler_test.go b/core/services/workflows/syncer/handler_test.go index e9b75e5a162..d6c0c56d0ad 100644 --- a/core/services/workflows/syncer/handler_test.go +++ b/core/services/workflows/syncer/handler_test.go @@ -617,64 +617,6 @@ func Test_workflowDeletedHandler(t *testing.T) { _, err = h.engineRegistry.Get(wfIDs) require.Error(t, err) }) - t.Run("success deleting non-existing workflow spec", func(t *testing.T) { - var ( - ctx = testutils.Context(t) - lggr = logger.TestLogger(t) - db = pgtest.NewSqlxDB(t) - orm = NewWorkflowRegistryDS(db, lggr) - emitter = custmsg.NewLabeler() - - binary = wasmtest.CreateTestBinary(binaryCmd, binaryLocation, true, t) - encodedBinary = []byte(base64.StdEncoding.EncodeToString(binary)) - config = []byte("") - secretsURL = "http://example.com" - binaryURL = "http://example.com/binary" - configURL = "http://example.com/config" - wfOwner = []byte("0xOwner") - - fetcher = newMockFetcher(map[string]mockFetchResp{ - binaryURL: {Body: encodedBinary, Err: nil}, - configURL: {Body: config, Err: nil}, - secretsURL: {Body: []byte("secrets"), Err: nil}, - }) - ) - - giveWFID, err := pkgworkflows.GenerateWorkflowID(wfOwner, "workflow-name", binary, config, secretsURL) - require.NoError(t, err) - - er := NewEngineRegistry() - store := wfstore.NewDBStore(db, lggr, clockwork.NewFakeClock()) - registry := capabilities.NewRegistry(lggr) - registry.SetLocalRegistry(&capabilities.TestMetadataRegistry{}) - rl, err := ratelimiter.NewRateLimiter(rlConfig) - require.NoError(t, err) - h := NewEventHandler( - lggr, - orm, - fetcher, - store, - registry, - emitter, - clockwork.NewFakeClock(), - workflowkey.Key{}, - rl, - WithEngineRegistry(er), - ) - - deleteEvent := WorkflowRegistryWorkflowDeletedV1{ - WorkflowID: giveWFID, - WorkflowOwner: wfOwner, - WorkflowName: "workflow-name", - DonID: 1, - } - err = h.workflowDeletedEvent(ctx, deleteEvent) - require.NoError(t, err) - - // Verify the record is deleted in the database - _, err = orm.GetWorkflowSpec(ctx, hex.EncodeToString(wfOwner), "workflow-name") - require.Error(t, err) - }) } func Test_workflowPausedActivatedUpdatedHandler(t *testing.T) {