update

smartcontractkit · Feb 26, 2025 · dead96b · dead96b
1 parent 6431aa2
commit dead96b
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/core/capabilities/ccip/ccipevm/addresscodec_test.go b/core/capabilities/ccip/ccipevm/addresscodec_test.go
@@ -24,20 +24,21 @@ func TestAddressStringToBytes(t *testing.T) {
 	require.Equal(t, want, got)
 }
 
-// func TestInvalidAddressBytesToString(t *testing.T) {
-//	addressCodec := AddressCodec{}
-//	addr := []byte{0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F, 0x10, 0x11, 0x12}
-//	_, err := addressCodec.AddressBytesToString(addr)
-//	require.Error(t, err)
-// }
-
 func TestInvalidAddressStringToBytes(t *testing.T) {
 	addressCodec := AddressCodec{}
 	addr := "0x000102030405060708090a0b0c0d0e0f1011121"
 	_, err := addressCodec.AddressStringToBytes(addr)
 	require.Error(t, err)
 }
 
+func TestInvalidHexString(t *testing.T) {
+	addressCodec := AddressCodec{}
+	addr := "0xZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ"
+	_, err := addressCodec.AddressStringToBytes(addr)
+	require.Error(t, err)
+}
+
+// TODO uncomment after CCIP supports EIP-55 checksum, https://smartcontract-it.atlassian.net/browse/CCIP-5340
 // func TestValidEVMAddress(t *testing.T) {
 //	addressCodec := AddressCodec{}
 //	addr := []byte{0xde, 0xad, 0xbe, 0xef, 0xde, 0xad, 0xbe, 0xef, 0xde, 0xad, 0xbe, 0xef, 0xde, 0xad, 0xbe, 0xef, 0xde, 0xad, 0xbe, 0xef}
@@ -47,9 +48,10 @@ func TestInvalidAddressStringToBytes(t *testing.T) {
 //	require.Equal(t, want, got)
 // }
 
-func TestInvalidHexString(t *testing.T) {
-	addressCodec := AddressCodec{}
-	addr := "0xZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ"
-	_, err := addressCodec.AddressStringToBytes(addr)
-	require.Error(t, err)
-}
+// TODO uncomment after CCIP supports EIP-55 checksum, https://smartcontract-it.atlassian.net/browse/CCIP-5340
+// func TestInvalidAddressBytesToString(t *testing.T) {
+//	addressCodec := AddressCodec{}
+//	addr := []byte{0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x0C, 0x0D, 0x0E, 0x0F, 0x10, 0x11, 0x12}
+//	_, err := addressCodec.AddressBytesToString(addr)
+//	require.Error(t, err)
+// }