pkg/solana: bump framework; pass context to select rpc #1043

jmank88 · 2025-02-04T22:13:10Z

Requires:

multinode: retry selection during initial dial; chains/txmgr: non-blocking start chainlink-framework#23

Supports:

bump framework; remove generic result type chainlink#15995

core ref: 683a2a82b2e65d042a4e1493aedc5fa11001705b

jmank88 · 2025-02-04T22:49:19Z

pkg/solana/utils/loader.go

Updated with context and expanded with other variants. Then moved here because integration-tests needed to use it.

jmank88 · 2025-02-04T22:50:15Z

pkg/solana/utils/utils.go

Moved to integration-test/utils since unused in main module (and this is not a test module anyways)

jmank88 · 2025-02-04T22:50:36Z

integration-tests/utils/utils.go

Just moved things from the internal utils package.

jmank88 · 2025-02-05T19:42:30Z

The smoke test passes in core, but has hung from this repo a few times 🤔
Edit: working now 🤷

jmank88 temporarily deployed to integration February 4, 2025 22:13 — with GitHub Actions Inactive

jmank88 had a problem deploying to integration February 4, 2025 22:13 — with GitHub Actions Failure

jmank88 temporarily deployed to integration February 4, 2025 22:13 — with GitHub Actions Inactive

jmank88 mentioned this pull request Feb 4, 2025

bump framework; remove generic result type smartcontractkit/chainlink#15995

Merged

jmank88 temporarily deployed to integration February 4, 2025 22:13 — with GitHub Actions Inactive

jmank88 force-pushed the select-rpc-ctx branch from 93cfb3e to 86816bc Compare February 4, 2025 22:47

jmank88 had a problem deploying to integration February 4, 2025 22:47 — with GitHub Actions Failure

jmank88 temporarily deployed to integration February 4, 2025 22:47 — with GitHub Actions Inactive

jmank88 had a problem deploying to integration February 4, 2025 22:47 — with GitHub Actions Error

jmank88 changed the title ~~pkg/solana: bump framwork; pass context to select rpc~~ pkg/solana: bump framework; pass context to select rpc Feb 4, 2025

jmank88 commented Feb 4, 2025

View reviewed changes

integration-tests/utils/utils.go

Copy link

Contributor Author

jmank88 Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved things from the internal utils package.

jmank88 force-pushed the select-rpc-ctx branch from 86816bc to d731fdf Compare February 4, 2025 22:52

jmank88 had a problem deploying to integration February 4, 2025 22:53 — with GitHub Actions Failure

jmank88 temporarily deployed to integration February 4, 2025 22:53 — with GitHub Actions Inactive

jmank88 force-pushed the select-rpc-ctx branch from d731fdf to f8187ca Compare February 4, 2025 23:10

jmank88 had a problem deploying to integration February 4, 2025 23:10 — with GitHub Actions Failure

jmank88 temporarily deployed to integration February 4, 2025 23:10 — with GitHub Actions Inactive

jmank88 force-pushed the select-rpc-ctx branch from f8187ca to f6e4ec8 Compare February 4, 2025 23:22

jmank88 temporarily deployed to integration February 4, 2025 23:22 — with GitHub Actions Inactive

jmank88 had a problem deploying to integration February 4, 2025 23:22 — with GitHub Actions Failure

jmank88 temporarily deployed to integration February 4, 2025 23:22 — with GitHub Actions Inactive

jmank88 force-pushed the select-rpc-ctx branch from f6e4ec8 to 2f104e2 Compare February 4, 2025 23:33

pavel-raykov approved these changes Feb 5, 2025

View reviewed changes

jmank88 requested review from krebernisak, archseer and Farber98 February 5, 2025 17:30

jmank88 had a problem deploying to integration February 5, 2025 17:42 — with GitHub Actions Error

jmank88 had a problem deploying to integration February 5, 2025 18:31 — with GitHub Actions Error

jmank88 had a problem deploying to integration February 5, 2025 19:08 — with GitHub Actions Error

jmank88 temporarily deployed to integration February 5, 2025 19:48 — with GitHub Actions Inactive

jmank88 temporarily deployed to integration February 5, 2025 19:54 — with GitHub Actions Inactive

jmank88 requested review from nicolasgnr, sdrug, augustbleeds, cfal, smickovskid, calvwang9, chray-zhang, yashnevatia, securemitchell, tt-cll, chris-de-leon-cll, eduard-cl and jlaveracll February 5, 2025 20:37

aalu1418 enabled auto-merge (squash) February 5, 2025 22:13

aalu1418 approved these changes Feb 5, 2025

View reviewed changes

aalu1418 merged commit c3ca047 into develop Feb 5, 2025
35 of 36 checks passed

aalu1418 deleted the select-rpc-ctx branch February 5, 2025 22:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pkg/solana: bump framework; pass context to select rpc #1043

pkg/solana: bump framework; pass context to select rpc #1043

jmank88 commented Feb 4, 2025 •

edited

Loading

jmank88 Feb 4, 2025

jmank88 Feb 4, 2025

jmank88 Feb 4, 2025

jmank88 commented Feb 5, 2025 •

edited

Loading

pkg/solana: bump framework; pass context to select rpc #1043

pkg/solana: bump framework; pass context to select rpc #1043

Conversation

jmank88 commented Feb 4, 2025 • edited Loading

jmank88 Feb 4, 2025

Choose a reason for hiding this comment

jmank88 Feb 4, 2025

Choose a reason for hiding this comment

jmank88 Feb 4, 2025

Choose a reason for hiding this comment

jmank88 commented Feb 5, 2025 • edited Loading

jmank88 commented Feb 4, 2025 •

edited

Loading

jmank88 commented Feb 5, 2025 •

edited

Loading