If localnet, be less strict on the expected chainID #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-cll
reviewed
Feb 4, 2025
| @@ -150,7 +151,9 @@ func (v *verifiedCachedClient) verifyChainID(ctx context.Context) (bool, error) | |||
|
|
|||
| // check chainID matches expected chainID | |||
| expectedChainID := strings.ToLower(v.expectedChainID) | |||
| if v.chainID != expectedChainID { | |||
| // if this is localnet, allow any chain ID as long as it's not spoofing an official network | |||
| ignore := v.chainID == "localnet" && !slices.Contains([]string{"mainnet", "testnet", "devnet"}, expectedChainID) | |||
There was a problem hiding this comment.
do we have these consts defined anywhere?
tt-cll
previously approved these changes
Feb 4, 2025
archseer
had a problem deploying
to
integration
GitHub Actions
Failure
tt-cll
approved these changes
Feb 4, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deployment tests we use a bunch of random identifiers to allow us to run multiple different solana chains at once. The current relayer implementation is quite rigid which causes a mismatch. This PR makes the check more permissive (but still disallows using official IDs on localnet)