From cc8b3ddf5967c2e7e26f314f73cb56a2f4c71583 Mon Sep 17 00:00:00 2001
From: Tate <tate.exon@smartcontract.com>
Date: Tue, 28 May 2024 07:45:02 -0600
Subject: [PATCH] Fix failure when there are go test issues that do not create
 -json logs (#725)

- metrics collection failure should not fail pipeline
- when go test fails, its exit code should fail the step when it pipes its output to other tools
---
 .github/workflows/relay.yml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/relay.yml b/.github/workflows/relay.yml
index 5eefe2890..76c14d55a 100644
--- a/.github/workflows/relay.yml
+++ b/.github/workflows/relay.yml
@@ -21,6 +21,7 @@ jobs:
           hostname: ${{ secrets.GRAFANA_INTERNAL_HOST }}
           this-job-name: Relay Run Unit Tests
           test-results-file: '{"testType":"go","filePath":"/tmp/gotest.log"}'
+        continue-on-error: true
       - name: Checkout sources
         uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
       - name: Setup go
@@ -42,7 +43,9 @@ jobs:
       - name: Build
         run: go build -v ./pkg/...
       - name: Test
-        run: go test ./pkg/... -json -tags integration -covermode=atomic -coverpkg=./... -coverprofile=integration_coverage.txt 2>&1 | tee /tmp/gotest.log | gotestloghelper -ci
+        run: |
+          set -o pipefail
+          go test ./pkg/... -json -tags integration -covermode=atomic -coverpkg=./... -coverprofile=integration_coverage.txt 2>&1 | tee /tmp/gotest.log | gotestloghelper -ci
       - name: Test with the race detector enabled
         run: go test ./pkg/... -v -race -count=10 -timeout=15m -covermode=atomic -coverpkg=./... -coverprofile=race_coverage.txt
       - name: Upload Go test results
@@ -51,5 +54,6 @@ jobs:
         with:
           name: go-relay-test-results
           path: |
+            /tmp/gotest.log
             ./race_coverage.txt
             ./integration_coverage.txt