From 74f726b4a203f60e85106ff41a6eed1959034ec8 Mon Sep 17 00:00:00 2001 From: Domino Valdano <2644901+reductionista@users.noreply.github.com> Date: Wed, 19 Feb 2025 22:27:23 -0800 Subject: [PATCH] Avoid modifying input buffer while decoding --- pkg/codec/encodings/binary/builder.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/pkg/codec/encodings/binary/builder.go b/pkg/codec/encodings/binary/builder.go index 3996fb69e..7b2835171 100644 --- a/pkg/codec/encodings/binary/builder.go +++ b/pkg/codec/encodings/binary/builder.go @@ -115,12 +115,16 @@ func (littleBigInt) serializeUnsigned(size int, i *big.Int) ([]byte, error) { } func (littleBigInt) deserializeSigned(size int, b []byte) *big.Int { - slices.Reverse(b) - bi, _ := bigbigendian.DeserializeSigned(size, b) + r := make([]byte, len(b)) + copy(r, b) + slices.Reverse(r) + bi, _ := bigbigendian.DeserializeSigned(size, r) return bi } func (littleBigInt) deserializeUnsigned(_ int, b []byte) *big.Int { - slices.Reverse(b) - return new(big.Int).SetBytes(b) + r := make([]byte, len(b)) + copy(r, b) + slices.Reverse(r) + return new(big.Int).SetBytes(r) }