commit/tokenprice: add async tokenprice observer #668
Merged
+325
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
commented
Feb 26, 2025
commit/chainfee/observation_async.go
Outdated
There was a problem hiding this comment.
The changes here are pretty much all logging related, I wanted to add contextual logging where possible to be able to visualize rounds better.
| @@ -54,26 +59,58 @@ func (p *processor) ObserveFChain(lggr logger.Logger) map[cciptypes.ChainSelecto | |||
| return fChain | |||
| } | |||
|
|
|||
| func (p *processor) ObserveFeedTokenPrices(ctx context.Context, lggr logger.Logger) cciptypes.TokenPriceMap { | |||
| if p.tokenPriceReader == nil { | |||
| type observer interface { | |||
There was a problem hiding this comment.
Intentionally written to be as close as possible to the existing async observers
There was a problem hiding this comment.
Why not creating a new file for the async observer? We would match the style used for chainfee. but this is nit
There was a problem hiding this comment.
Its alright, this code will get deleted soon-ish anyway once we do the per-node cache.
makramkd
commented
Feb 26, 2025
Comment on lines
32
to
35
| - cmd: cd integration-tests/smoke/ccip && go test ccip_gas_price_updates_test.go -timeout 12m -test.parallel=2 -count=1 -json | ||
| name: "Gas Price Updates Test" | ||
| - cmd: cd integration-tests/smoke/ccip && go test ccip_token_price_updates_test.go -timeout 12m -test.parallel=2 -count=1 -json | ||
| name: "Token Price Updates Test" |
There was a problem hiding this comment.
Added for additional coverage.
can only run in docker at the moment
makramkd
requested review from
winder,
asoliman92,
matYang,
dimkouv,
mateusz-sekara,
0xAustinWang and
b-gopalswami
|
|
Token prices test passes in CL. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an asynchronous token price
observerimplementation that follows what is being done inmerklerootandchainfee.In the future, we'd want to potentially explore having these caches on a node-level rather than a plugin level to get even more performance gains.
The token price integration test couldn't be added because it requires docker, in a follow up will fix that and add it to this CI.