Yet another attempt to handle the unknown cause of build failures.

Author: smaillet

.github/workflows/pr-build.yml

@@ -26,7 +26,6 @@ jobs:
         uses: actions/checkout@v4
         with:
            persist-credentials: false
-           fetch-depth: 0
 
       - name: Build Source
         run: .\Build-All.ps1 -ForceClean -BuildMode Source
@@ -61,7 +60,6 @@ jobs:
         uses: actions/checkout@v4
         with:
            persist-credentials: false
-           fetch-depth: 0
 
       - name: Build Docs
         run: .\Build-Docs.ps1 -FullInit -Configuration Release

.github/workflows/release-build.yml

@@ -12,10 +12,9 @@ jobs:
         uses: actions/checkout@v2
         with:
           persist-credentials: false
-          fetch-depth: 0
 
       - name: Build Source
-        run: .\Build-All.ps1
+        run: .\Build-All.ps1 -FullInit
 
       - name: Publish Artifacts
         uses: actions/upload-artifact@v4

Build-Docs.ps1

@@ -73,11 +73,9 @@ try
     $buildInfo = Initialize-BuildEnvironment -FullInit:$FullInit
     $msBuildPropertyList = ConvertTo-PropertyList @{
         Configuration = $Configuration
+        RunAnalyzers = 'false'
     }
 
-    Write-Information "Current Build information"
-    Show-FullBuildInfo $buildInfo
-
     # make sure the supported tool is installed.
     Invoke-External dotnet tool install --global docfx --version $docFXToolVersion | Out-Null
 
@@ -112,26 +110,12 @@ try
         # Thus, for now, this uses the docfx build phase.]
         "$([DateTime]::UtcNow.ToString('o'))" | Out-File -Path (Join-Path $docsOutputPath '.nojekyll')
 
-        if($buildInfo["IsAutomatedBuild"])
-        {
-            Write-Information "Building analyzer so it is available when building docs."
-            # In automated builds the analyzer doesn't exist yet and it isn't listed in the docfx.json so that won't
-            # build it either. There's nothing to document (at this point it is entirely internal). So it MUST be built
-            # directly to support automated builds.
-            $analyzerProjPath = Join-Path 'src' 'ReferenceEqualityVerifier' 'ReferenceEqualityVerifier' 'ReferenceEqualityVerifier.csproj'
-            Invoke-External dotnet build '--tl:off' $analyzerProjPath '-c' $Configuration
-        }
-        else
-        {
-            Write-Information "Not an automated build; assuming analyzer already built"
-        }
-
         $fullBuildNumber = Get-FullBuildNumber
         push-location './docfx'
         try
         {
             Write-Information "Building docs [FullBuildNumber=$fullBuildNumber]"
-            Invoke-External docfx '-m' _buildVersion=$fullBuildNumber '-o' $docsOutputPath '--warningsAsErrors'
+            Invoke-External docfx '-m' _buildVersion=$fullBuildNumber '-o' $docsOutputPath '--warningsAsErrors' '--property' $msBuildPropertyList
         }
         finally
         {

PsModules/CommonBuild/CommonBuild.psm1

@@ -76,6 +76,13 @@ function Get-FunctionsToExport
     return $bldr.ToString()
 }
 
+# force preferences to what is expected
+# see: https://github.com/PowerShell/PowerShell/issues/4568
+# there is NO good solution to this beyond setting a global preference OR specifying the preference on EVERY CALL
+# '`tis a silly thing' - The whole PS preferences settings is a nightmarish mess.
+$InformationPreference = 'Continue'
+$ErrorInformationPreference = 'Stop'
+
 # get public/Private function definition files
 $Public = @( Get-ChildItem -Path (Join-path $PSScriptroot 'Public' '*.ps1') -ErrorAction SilentlyContinue )
 $Private = @( Get-ChildItem -Path (Join-path $PSScriptroot 'Private' '*.ps1') -ErrorAction SilentlyContinue )

repo-buildutils.ps1

@@ -21,7 +21,6 @@ Set-StrictMode -version 3.0
 $ErrorActionPreference = "Stop"
 $InformationPreference = "Continue"
 
-
 function Initialize-BuildEnvironment
 {
 <#