Merge branch 'UbiquityDotNET:develop' into develop

Author: smaillet

.editorconfig

@@ -5,10 +5,21 @@ root = true
 indent_style = space
 indent_size = 4
 insert_final_newline = true
+tab_width = 4
+end_of_line = crlf
+# until [VSSpellChecker bug 277](https://github.com/EWSoftware/VSSpellChecker/issues/277)
+# is fixed, disable the analyzers. It's more of a PITA than a help
+# VSSPELL: Disable the analyzers until Bug 277 is fixed.
+vsspell_code_analyzers_enabled = false
+
+# VSSPELL: Spell checker settings for all files
+vsspell_section_id = 1c7003ec377c4bd9bb3c509d29770210
+vsspell_ignored_words_1c7003ec377c4bd9bb3c509d29770210 = File:.\IgnoredWords.dic|bar
 
 # match VS generated formatting for MSBuild project files
 [*.*proj,*.props,*.targets]
 indent_size = 2
+tab_width = 2
 
 # match ISO standard requirement for C/C++
 [*.c,*.h,*.cpp]
@@ -56,6 +67,28 @@ csharp_space_between_method_declaration_name_and_open_parenthesis = false
 csharp_space_around_declaration_statements = ignore
 csharp_space_between_method_call_parameter_list_parentheses = true
 csharp_space_between_square_brackets = true
+csharp_using_directive_placement = outside_namespace:error
+csharp_prefer_simple_using_statement = true:error
+csharp_prefer_braces = true:error
+csharp_style_namespace_declarations = block_scoped:error
+csharp_style_prefer_method_group_conversion = true:silent
+csharp_style_prefer_top_level_statements = false:error
+csharp_style_prefer_primary_constructors = false:silent
+csharp_prefer_system_threading_lock = true:suggestion
+csharp_style_expression_bodied_constructors = false:error
+csharp_style_expression_bodied_lambdas = true:warning
+csharp_style_expression_bodied_local_functions = true:suggestion
+dotnet_diagnostic.RECS0001.severity = error
+dotnet_diagnostic.SA1023.severity = none
+dotnet_diagnostic.SA1124.severity = none
+csharp_style_allow_embedded_statements_on_same_line_experimental = false:error
+dotnet_diagnostic.SA1512.severity = none
+dotnet_diagnostic.SA1129.severity = error
+csharp_style_prefer_null_check_over_type_check = true:error
+csharp_prefer_simple_default_expression = true:error
+csharp_space_between_method_declaration_parameter_list_parentheses = true
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = true
+dotnet_diagnostic.SA0001.severity = none
 
 # Analysis and refactoring rules for Ubiquity.NET
 # Description: Code analysis rules for Ubiquity.NET projects
@@ -65,6 +98,17 @@ csharp_space_between_square_brackets = true
 # Code files
 [*.{cs,vb}]
 
+# IDE0059: Unnecessary assignment of a value
+dotnet_diagnostic.IDE0059.severity = none
+
+# CA1420: Property, type, or attribute requires runtime marshalling
+dotnet_diagnostic.CA1420.severity = error
+
+# IDE0079: Remove unnecessary suppression
+dotnet_diagnostic.IDE0079.severity = none
+
+# SYSLIB1092: The usage of 'LibraryImportAttribute' does not follow recommendations.
+dotnet_diagnostic.SYSLIB1092.severity = warning
 
 dotnet_diagnostic.AD0001.severity = none
 
@@ -1272,8 +1316,6 @@ dotnet_diagnostic.SA1127.severity = error
 
 dotnet_diagnostic.SA1128.severity = error
 
-dotnet_diagnostic.SA1129.severity = error
-
 dotnet_diagnostic.SA1130.severity = error
 
 dotnet_diagnostic.SA1131.severity = error
@@ -1392,8 +1434,6 @@ dotnet_diagnostic.SA1510.severity = error
 
 dotnet_diagnostic.SA1511.severity = error
 
-dotnet_diagnostic.SA1512.severity = error
-
 dotnet_diagnostic.SA1513.severity = error
 
 dotnet_diagnostic.SA1514.severity = error
@@ -1488,3 +1528,69 @@ dotnet_diagnostic.SX1101.severity = error
 
 # CA2007: Consider calling ConfigureAwait on the awaited task
 dotnet_diagnostic.CA2007.severity = none
+
+[*.{cs,vb}]
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+dotnet_style_coalesce_expression = true:warning
+dotnet_style_null_propagation = true:warning
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:error
+dotnet_style_prefer_auto_properties = true:error
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:warning
+dotnet_style_prefer_simplified_boolean_expressions = true:error
+dotnet_style_prefer_conditional_expression_over_assignment = true:warning
+dotnet_style_prefer_conditional_expression_over_return = true:warning
+dotnet_style_explicit_tuple_names = true:warning
+dotnet_style_operator_placement_when_wrapping = beginning_of_line
+dotnet_style_prefer_inferred_tuple_names = true:suggestion
+dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion
+dotnet_style_prefer_compound_assignment = true:error
+dotnet_style_prefer_simplified_interpolation = true:suggestion
+dotnet_style_prefer_collection_expression = when_types_loosely_match:suggestion
+dotnet_style_namespace_match_folder = true:suggestion
+dotnet_diagnostic.MSTEST0032.severity = none

.gitattributes

@@ -0,0 +1,2 @@
+# Set the default behavior, in case people don't have core.autocrlf set in global settings
+* text=auto

.github/ISSUE_TEMPLATE/bug_report.md

@@ -13,8 +13,7 @@ Please provide the following information when submitting an issue.
 
 **.NET Framework Used:**
 
-- [ ] .NET Core 3.0.0
-- [ ] .NET Core 3.1.0
+- [ ] .NET 9.0
 - [ ] Something else
 
 **OS Environment:**

.github/ISSUE_TEMPLATE/feature_request.md

@@ -10,7 +10,7 @@ assignees: ''
 **Is your feature request related to a problem? Please describe.**
 > NOTE: 
 > Feature requests are intended to request a new feature or a change in the intended/designed
-> functionality (a.k.a. DCR). They should not be used to report bugs, which are incorrect
+> functionality (a.k.a. "Design Change Request" [DCR]). They should not be used to report bugs, which are incorrect
 > implementations of the designed functionality.
 
 A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

.github/workflows/pr-build.yml

@@ -3,45 +3,52 @@ on:
   push:
     branches:
       - develop
-      - llvm_10
+      - LLVM20
+
     paths-ignore:
       - '**.md'
+      - '**.dic'
+
   pull_request:
     branches:
       - develop
-      - llvm_10
+      - LLVM20
+
+    paths-ignore:
+      - '**.md'
+      - '**.dic'
+
 jobs:
   build:
     runs-on: windows-latest
     steps:
       - name: Checkout Repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
            persist-credentials: false
-           fetch-depth: 0
 
       - name: Build Source
         run: .\Build-All.ps1 -ForceClean -BuildMode Source
 
       - name: Publish build logs
         if: always() && github.event_name == 'pull_request'
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
             name: Build Logs
             path: .\BuildOutput\BinLogs
 
       - name: Publish NuGET Packages
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
-            name: Nuget Packages
-            path: .\BuildOutput\Nuget
+            name: NuGet Packages
+            path: .\BuildOutput\NuGet
 
       - name: Run Tests
         run: .\Invoke-UnitTests.ps1
 
       - name: Publish test logs
         if: always()
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
             name: Test Logs
             path: .\BuildOutput\Test-Results
@@ -50,25 +57,22 @@ jobs:
     runs-on: windows-latest
     steps:
       - name: Checkout Repo
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
            persist-credentials: false
-           fetch-depth: 0
 
       - name: Build Docs
-        run: .\Build-All.ps1 -ForceClean -BuildMode Docs
+        run: .\Build-Docs.ps1 -FullInit -Configuration Release
 
       - name: Upload docs artifact
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
             name: Docs
             path: .\BuildOutput\docs\current
 
       - name: Publish build logs
         if: always() && github.event_name == 'pull_request'
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
             name: Build Logs
             path: .\BuildOutput\BinLogs
-
-

.github/workflows/release-build.yml

@@ -12,23 +12,22 @@ jobs:
         uses: actions/checkout@v2
         with:
           persist-credentials: false
-          fetch-depth: 0
 
       - name: Build Source
-        run: .\Build-All.ps1
+        run: .\Build-All.ps1 -FullInit
 
       - name: Publish Artifacts
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
-          name: Nuget Packages
-          path: .\BuildOutput\Nuget
+          name: NuGet Packages
+          path: .\BuildOutput\NuGet
 
       - name: Run Tests
         run: .\Invoke-UnitTests.ps1
 
       - name: Publish test logs
         if: always()
-        uses: actions/upload-artifact@v1
+        uses: actions/upload-artifact@v4
         with:
             name: Test Logs
             path: .\BuildOutput\Test-Results

.gitignore

@@ -24,8 +24,10 @@ bld/
 # Docs updated only by CI builds for GitHub Pages
 [Dd]ocs/
 
-# Visual Studo 2015 cache/options directory
+# Visual Studio 2015 cache/options directory
 .vs/
+# Uncomment if you have tasks that create the project's static files in wwwroot
+#wwwroot/
 
 # MSTest test Results
 [Tt]est[Rr]esult*/
@@ -91,25 +93,45 @@ _ReSharper*/
 !**/packages/build/
 # Uncomment if necessary however generally it will be regenerated when needed
 #!**/packages/repositories.config
+# NuGet v3's project.json files produces more ignoreable files
+*.nuget.props
+*.nuget.targets
 
-# Windows Azure Build Output
+# Microsoft Azure Build Output
 csx/
 *.build.csdef
 
-# Windows Store app package directory
+# Microsoft Azure Emulator
+ecf/
+rcf/
+
+# Windows Store app package directories and files
 AppPackages/
+BundleArtifacts/
+Package.StoreAssociation.xml
+_pkginfo.txt
 
-# Others
+# Visual Studio cache files
+# files ending in .cache can be ignored
 *.[Cc]ache
+# but keep track of directories ending in .cache
+!*.[Cc]ache/
+
+# Others
 ClientBin/
 ~$*
 *~
 *.dbmdl
 *.dbproj.schemaview
+*.jfm
 *.pfx
 *.publishsettings
 node_modules/
-bower_components/
+orleans.codegen.cs
+
+# Since there are multiple workflows, uncomment next line to ignore bower_components
+# (https://github.com/github/gitignore/pull/1529#issuecomment-104372622)
+#bower_components/
 
 # RIA/Silverlight projects
 Generated_Code/
@@ -122,9 +144,21 @@ Backup*/
 UpgradeLog*.XML
 UpgradeLog*.htm
 
+# SQL Server files
+*.mdf
+*.ldf
+
+# Business Intelligence projects
+*.rdl.data
+*.bim.layout
+*.bim_*.settings
+
 # Microsoft Fakes
 FakesAssemblies/
 
+# GhostDoc plugin setting file
+*.GhostDoc.xml
+
 # Node.js Tools for Visual Studio
 .ntvs_analysis.dat