Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a plan to make this project fully compatible with rugged? #2

Open
zhuangbiaowei opened this issue Jan 14, 2019 · 4 comments
Open

Comments

@zhuangbiaowei
Copy link

e.g.

repo.last_commit.oid return -> String

but,in this lib:

repo.last_commit.target_id.to_s return -> String

@smacker
Copy link
Owner

smacker commented Feb 13, 2019

The aim is to be as compatible as possible but most probably it will be impossible to archive 100% compatibility.
Please also keep in mind that the project is at a very early stage right now.

@zhuangbiaowei
Copy link
Author

I am also working on this project recently. If you are interested, I hope to submit PR to you.

https://github.com/zhuangbiaowei/libgit2.cr

@bew
Copy link

bew commented Mar 7, 2019

@zhuangbiaowei Nice work!

Since you did quite a lot of changes, I'd suggest to make multiple small PR for each kind of changes you did.
This way the reviewer (@smacker) does have too much code to review and you get better feedback on it.

@zhuangbiaowei
Copy link
Author

@bew Thank you for your suggestion.

I am willing to submit some smaller PRs. However, I am more worried about @smacker. It seems that his time is not very certain. In my comments, he will take a long time to reply...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants