Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCB v1.0 regression tests #690

Open
laurentsimon opened this issue Aug 17, 2023 · 0 comments
Open

GCB v1.0 regression tests #690

laurentsimon opened this issue Aug 17, 2023 · 0 comments
Labels
area:gcb Issue with the gcb verifier area:tests Issue with unit tests
Milestone
GCB v1.0 provenan...

Comments

@laurentsimon
Copy link
Contributor

We need to wait till GCB v1.0 support is available to create containers, we should happen last week of Aug or so.
@laurentsimon laurentsimon mentioned this issue Aug 17, 2023
Merged
laurentsimon added a commit that referenced this issue Aug 18, 2023
@laurentsimon @ianlewis
feat: gcb v1.0 support (#691)
58eede7 
closes #683

This is a large PR, but there is not much new code.

The code adding support for v1.0 is under:
- verifiers/internal/gcb/slsaprovenance/v1.0/*
- verifiers/internal/gcb/slsaprovenance/provenance.go

The rest is mostly some re-factoring needed

Remaining is regression tests, tracked in
#690

---------

Signed-off-by: laurentsimon <[email protected]>
Signed-off-by: laurentsimon <[email protected]>
Co-authored-by: Ian Lewis <[email protected]>
@ianlewis ianlewis added area:gcb Issue with the gcb verifier area:tests Issue with unit tests labels Aug 28, 2023
ramonpetgrave64 pushed a commit to ramonpetgrave64/slsa-verifier that referenced this issue Apr 18, 2024
@renovate-bot
Update module github.com/sigstore/cosign to v1.11.1 (slsa-framework#690)
5b0c704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:gcb Issue with the gcb verifier area:tests Issue with unit tests
Projects
None yet
Milestone
GCB v1.0 provenance support
Development

No branches or pull requests
2 participants
@ianlewis @laurentsimon