-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announcements and Commands - revamped #46
Comments
The last option can be used but with no keys, so in practice it becomes an array of objects: announcements:
- trigger: streak
interval: 5
message: '%player% is on a hunt!'
- trigger: streak
amount: 100
message: '%player% killed 100 players in a row!' Parses as: {
"announcements": [
{
"message": "%player% is on a hunt!",
"trigger": "streak",
"interval": 5
},
{
"amount": 100,
"trigger": "streak",
"message": "%player% killed 100 players in a row!"
}
]
} Since we're now managing intervals, we'll probably have to loop over all options at runtime anyway to figure out which ones should trigger... |
Updated requirements based on new features. After reflecting after forgetting we had this issue and this discussion... I am not sure I like the way of setting up these nodes to split up announcements and commands so early. I think there might be a reason to keep them closer together, maybe:
Writing this up I came up with something a bit more flexible but of course more complicated 🥇
All above things apply like further configurable options like "interval or absolute" and "minimal or maximal" and I need to think about whether we always have all values in there as examples or if we can omit values to have less spam Edit: Command ideas:
|
Since no-one is complaining about this, I have to. The current way of setting up announcements and commands is very strict and narrow mineded, to a degree where it only makes sense for a fringe minority.
There needs to be a dedicated block for both - that supports the following options:
As this becomes more and more complicated, we might want to look into setting this up with commands, and relying on one YML file per setting that can be combined. However, that is up to the server owner to decide, really.
Some examples here, I think this makes the most sense in a way that we can suppot the old way and the new way. This can be expanded to be multiline just like before, and I prefer this over a more verbose setup like
I am not sure. I really prefer the numbers being used here instead of stringified integers as keys.
Thoughts, anyone? I am up for totally different solutions :)
The text was updated successfully, but these errors were encountered: