Skip to content
This repository was archived by the owner on Sep 10, 2019. It is now read-only.

No tests... #6

Open
sleepdeprecation opened this issue Aug 22, 2013 · 1 comment
Open

No tests... #6

sleepdeprecation opened this issue Aug 22, 2013 · 1 comment
Assignees
Labels

Comments

@sleepdeprecation
Copy link
Owner

There are no tests. While I'm not totally for tests m they provide an extra layer of security, and potential collaborators may not know how things are supposed to work.

Mainly, they make sure we don't accidentally screw up the public API, which should be constant between versions...

I've assigned this to myself because I want to look into java unit testing.

sleepdeprecation pushed a commit that referenced this issue Aug 24, 2013
As per #6, I started working on tests. There's currently only a really
simple get request test, but it passes, which is nice...

Tests are using jUnit 4, if you want to try them out yourself.
@sleepdeprecation
Copy link
Owner Author

There are a couple tests now. Mostly making sure that the HTTPRequest class is doing it's job correctly. There's one minor problem in my eye, and it's that we can't guarantee that the http request creator I built (the MockClient) is generating real, correct http requests. I assume it does, but it's technically not tested...

Nothing else has been tested, because we can't really test anything else... I mean, the handler factory can't be tested (other than, does HTTPHandlerFactory.determine handler() return a DeathHandler).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant