Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: syncGroups does error printing, but not slog #322

Closed
palfrey opened this issue Jan 20, 2025 · 2 comments
Closed

bug: syncGroups does error printing, but not slog #322

palfrey opened this issue Jan 20, 2025 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@palfrey
Copy link

palfrey commented Jan 20, 2025

Describe the bug
During slogGroups, various errors can occur (e.g. Error: cannot create google service: google: error getting JWT config from Service Account: invalid character '.' looking for beginning of value) which get dumped to console, but not handed through slog, which makes determining their error level in a lambda hard as they just show up as info level.

To Reproduce
Steps to reproduce the behavior:

  1. Have a broken config
  2. Run idpscim in a lambda

Expected behavior
slog.Error call so we get properly tagged error logs

Additional information
Would a PR that added slog.Error bits to those be wanted?

@palfrey palfrey added the bug Something isn't working label Jan 20, 2025
@palfrey
Copy link
Author

palfrey commented Feb 8, 2025

@christiangda ?

@christiangda christiangda self-assigned this Feb 8, 2025
@christiangda christiangda added this to the v0.30.2 milestone Feb 8, 2025
christiangda added a commit that referenced this issue Feb 8, 2025
wrap errors for fuctions and use slog to print the wrapped errors
@christiangda
Copy link
Contributor

christiangda commented Feb 8, 2025

Thank you very much @palfrey for reporting this issue, I fixed this on PR #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants