Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Enhancements #4

Open
cryogenian opened this issue Apr 19, 2017 · 1 comment
Open

Enhancements #4

cryogenian opened this issue Apr 19, 2017 · 1 comment

Comments

@cryogenian
Copy link
Member

Make AST safe by constructions.

I'm almost sure that some recursion points in SqlF are in wrong places. E.g. it's possible to create CASE and print it but the output isn't correct sql^2 and emits an error during parsing.

The idea is about at least introducing Expression type that handles identifiers, literals and operators.
Other thing is GROUP BY, keys should be NonEmpty List a or SELECT should take not Maybe (GroupBy a) but GroupBy a. There are few such things.

Make parser and gen coalgebraic

This one is heavily depending on making AST safe by construction.

Preserve position information during tokenizing

It's vanished right now.

@cryogenian cryogenian mentioned this issue Apr 19, 2017
@natefaubion
Copy link
Contributor

The position information and printing issues are taken care of in the latest release. We now have lots of test cases which parse -> print -> parse and compare ASTs as equivalent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants