Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls viewDidLoad again when dismissed if base navigation controller is presented by a tab bar #199

Open
4 of 9 tasks
tesddev opened this issue May 30, 2023 · 0 comments
Open
4 of 9 tasks

Comments

@tesddev
Copy link

tesddev commented May 30, 2023

Description

When the navigation stack is originally presented by or from a tab bar, dismissing the panModal page calls the viewDidLoad again, rather than just the viewWillAppear and viewDidAppear alone.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

PanModal version: 1.2.7

iOS version: 11.0

Steps to reproduce:

  1. Create a tab bar with at least 2 view controllers
  2. Present pan modal from one of the screens
  3. Put breakpoints in the viewdidLoad and viewWillAppear

Expected result:

It is expected to call only viewDIdAppear and viewWillAppear

Actual result:

It calls viewWillAppear and viewDidAppear, as well as viewDidLoad. ViewDidLoad should not be called.

Attachments:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant