Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad popover presentation cutting off in example project. Not laying out correctly #175

Open
4 of 9 tasks
teradyl opened this issue Mar 20, 2022 · 0 comments
Open
4 of 9 tasks

Comments

@teradyl
Copy link

teradyl commented Mar 20, 2022

Description

My true issue is that the height of the popover in my app is not working on some iPads (9.7 inch for example). It has too much top margin and cuts off the bottom of my view.

However, I noticed that the example project is also not laying out properly and cutting off the top (instead of the bottom in my case), and if we can get to the bottom of this problem it may solve my issue too.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.

Bug Report

Filling out the following details about bugs will help us solve your issue sooner.

Reproducible in:

PanModal version: 1.2.7~

iOS version: iOS 15.4 with iPad Pro 9.7 inch simulator and device~~

Steps to reproduce:

  1. Open Sample project
  2. Add sourceRect & sourceView like so to the presentPanModal in SampleViewController: presentPanModal(rowType.presentable.rowVC, sourceView: view, sourceRect: CGRect(x: 150, y: 150, width: 300, height: 300))
  3. Note how some of the examples like Alert are cut off at the top

Expected result:

Cells are not cut off at the top

Actual result:

Cell at the top is cut off

Attachments:

Logs, screenshots, screencast, sample project, funny gif, etc.

simulator_screenshot_DD12CCFC-3D7E-4BC8-9803-4F4D54493360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant