Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating AWS S3 SDK to v2 #1402

Closed
2 of 6 tasks
seratch opened this issue Dec 3, 2024 · 3 comments · Fixed by #1403
Closed
2 of 6 tasks

Migrating AWS S3 SDK to v2 #1402

seratch opened this issue Dec 3, 2024 · 3 comments · Fixed by #1403
Labels
dependencies Pull requests that update a dependency file enhancement M-T: A feature request for new functionality project:bolt
Milestone

Comments

@seratch
Copy link
Member

seratch commented Dec 3, 2024

As reported at #1168 (review), our optional dependency AWS S3 client SDK must be migraded to its v2 by the end of 2025.

Both groupId and artifactId are different:

-            <groupId>com.amazonaws</groupId>
-            <artifactId>aws-java-sdk-s3</artifactId>
+            <groupId>software.amazon.awssdk</groupId>
+            <artifactId>s3</artifactId>

Here is a version range example:

-        <aws.s3.version>[1.12.62,1.13.0)</aws.s3.version>
+        <aws.s3.version>[2.29.24,3)</aws.s3.version>

V2 is fully source-code incompatible, so this work requires rewriting the modules relying on the AWS SDK plus testing the behavior is still the same. It seems there is no need to migrate "aws-lambda-java-core" to something new this time.

See also:

We may want to try the migration tool if it works well for us:

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please make sure if this topic is specific to this SDK. For general questions/issues about Slack API platform or its server-side, could you submit questions at https://my.slack.com/help/requests/new instead. 🙇

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt dependencies Pull requests that update a dependency file good first issue labels Dec 3, 2024
@seratch seratch added this to the 1.x milestone Dec 3, 2024
@seratch seratch changed the title (Set a clear title describing your idea) Migrating AWS S3 SDK to v2 Dec 3, 2024
@Ankush1oo8
Copy link

So to change only dependicies or other code also

@seratch
Copy link
Member Author

seratch commented Dec 4, 2024

Thanks for your interest! but I started working on this. Hope we can work together for future tasks

@acharyashashank
Copy link

seratch added a commit to seratch/java-slack-sdk that referenced this issue Dec 5, 2024
seratch added a commit to seratch/java-slack-sdk that referenced this issue Dec 5, 2024
@seratch seratch closed this as completed in 26dba31 Dec 6, 2024
@seratch seratch modified the milestones: 1.x, 1.45.0 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement M-T: A feature request for new functionality project:bolt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants