From 4f9879ff8069ef1b32ec96e6c9a95a8e4059c0e7 Mon Sep 17 00:00:00 2001 From: Ankur Oberoi Date: Mon, 25 Jun 2018 11:01:46 +0900 Subject: [PATCH 1/2] Update message.coffee --- src/message.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/message.coffee b/src/message.coffee index 26b28f7e..dc0f6012 100644 --- a/src/message.coffee +++ b/src/message.coffee @@ -91,7 +91,7 @@ class SlackTextMessage extends TextMessage # flatten any attachments into text if @rawMessage.attachments - attachment_text = @rawMessage.attachments.map(a -> a.fallback).join("\n") + attachment_text = @rawMessage.attachments.map((a) -> a.fallback).join("\n") text = text + "\n" + attachment_text # Replace links in text async to fetch user and channel info (if present) From 2f02dea8f0fecb88c938946d4eeb3c294e7ee80e Mon Sep 17 00:00:00 2001 From: Ankur Oberoi Date: Tue, 3 Jul 2018 16:48:13 -0700 Subject: [PATCH 2/2] add test for attachment flattening --- test/message.coffee | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/message.coffee b/test/message.coffee index f0df81b6..97300d83 100644 --- a/test/message.coffee +++ b/test/message.coffee @@ -129,6 +129,17 @@ describe 'buildText()', -> message.buildText @client, () -> client.robot.logger.logs?.error.length.should.equal 1 + it 'Should flatten attachments', -> + message = @slacktextmessage + client = @client + message.rawMessage.text = 'foo bar' + message.rawMessage.attachments = [ + { fallback: 'first' }, + { fallback: 'second' } + ] + message.buildText @client, () -> + message.text.should.equal 'foo bar\nfirst\nsecond' + describe 'replaceLinks()', ->