Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails #5

Open
wagnerst opened this issue Jul 8, 2014 · 6 comments
Open

Build fails #5

wagnerst opened this issue Jul 8, 2014 · 6 comments

Comments

@wagnerst
Copy link
Contributor

wagnerst commented Jul 8, 2014

Hi, on a current Mac OS system, the build fails because malloc.h is not at the place you expect that to be. I fixed it for me by a symbolic link but that can only be a workaround. It would be better fixed in the build script.

@petersenna
Copy link

Hi,

Thanks for the message.

Can you send me more details? I don't have any MacOS for testing.

Where did you created the link and where it points to?

Thanks!

On Tue, Jul 8, 2014 at 9:46 AM, wagnerst [email protected] wrote:

Hi, on a current Mac OS system, the build fails because malloc.h is not at
the place you expect that to be. I fixed it for me by a symbolic link but
that can only be a workaround. It would be better fixed in the build script.


Reply to this email directly or view it on GitHub
#5.

Peter

@wagnerst
Copy link
Contributor Author

wagnerst commented Jul 8, 2014

I ran this:
sudo ln -s /usr/include/malloc/malloc.h /usr/include/malloc.h
from
http://hintsforums.macworld.com/archive/index.php/t-2023.html

@petersenna
Copy link

I'll fix it and let you know.

Thanks for reporting this issue.

On Tue, Jul 8, 2014 at 10:11 AM, wagnerst [email protected] wrote:

I ran this:
sudo ln -s /usr/include/malloc/malloc.h /usr/include/malloc.h
from
http://hintsforums.macworld.com/archive/index.php/t-2023.html


Reply to this email directly or view it on GitHub
#5 (comment).

Peter

@petersenna
Copy link

I'm sorry, I have no idea why I'm receiving those E-mails. I got confused
and I was assuming those were reports on one of my repositories, which is
not the case.

Sorry, I can't help.

On Tue, Jul 8, 2014 at 10:22 AM, Peter Senna Tschudin <[email protected]

wrote:

I'll fix it and let you know.

Thanks for reporting this issue.

On Tue, Jul 8, 2014 at 10:11 AM, wagnerst [email protected]
wrote:

I ran this:
sudo ln -s /usr/include/malloc/malloc.h /usr/include/malloc.h
from
http://hintsforums.macworld.com/archive/index.php/t-2023.html


Reply to this email directly or view it on GitHub
#5 (comment).

Peter

Peter

@skyhover
Copy link
Owner

Thank you for the information!

It seems a more system-compatible way to fix this issue is
to replace the line that includes malloc.h in the "src/lsh/sources/headers.h" with these (as suggested in the above link):

#if !defined(__APPLE__) 
#include <malloc.h>
#endif

But I don't have any MacOS to test. Is it possible if you help to remove your symlink and test this solution and re-build again?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@skyhover @petersenna @wagnerst and others