Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cascading does not take into account source keys #447

Closed
rocketraman opened this issue Sep 17, 2024 · 0 comments · Fixed by #448
Closed

Cascading does not take into account source keys #447

rocketraman opened this issue Sep 17, 2024 · 0 comments · Fixed by #448

Comments

@rocketraman
Copy link
Contributor

rocketraman commented Sep 17, 2024 •
edited
Loading

When we cascade map nodes, the sourceKey is lost.

This breaks denormalization for the map and Hikari data source decoders, because denormalization uses the sourceKey to restore the original key value to the target.

This is in a sense a regression of path normalization, which added the sourceKey concept.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cascader should carry through the source key from the override rocketraman/hoplite
1 participant
@rocketraman