Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup Table for Player names #4

Open
pssguy opened this issue Mar 27, 2018 · 2 comments
Open

Lookup Table for Player names #4

pssguy opened this issue Mar 27, 2018 · 2 comments

Comments

@pssguy
Copy link

pssguy commented Mar 27, 2018

Thanks for creating package and keeping scores up to date

In the atp_players and wta_players datasets you have a unique player_id to link to other datasets
However, it is not used in, say, the _elo files (although player name, if unique, can be substituted)
or the -_odds which is even more problematic

Any chance of creating a lookup table to cover this, please

@skoval
Copy link
Owner

skoval commented Apr 6, 2018

Just added a lookup table to match matchid/player_id between the odds and atp_matches (see atp_odds_match_lookup, wta_odds_match_lookup). (Also updated betting data at the same time)

For the elo tables, the player name should be the same as "name" in atp_players/wta_players

@pssguy
Copy link
Author

pssguy commented Apr 6, 2018

Thanks very much. Have not looked at the look up tables in detail yet, but unless I'm missing something there are lots of duplicated names in the atp_players file

atp_players %>% 
  count(name, sort = TRUE) %>% 
  filter(n>1) %>% 
  tally()

Gives a total of 848. From a cursory examination, most of these look same person repeated more than once - sometimes with more info in. Though, of course, there could be different people with the same name, potentially

Anyways, do not go to too much trouble on my behalf. I'll probably just write a one-off blog post on the package, excluding tables with possible issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants