Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets are no more showed on the UI #1059

Open
rafaarcangel opened this issue May 22, 2024 · 1 comment
Open

Secrets are no more showed on the UI #1059

rafaarcangel opened this issue May 22, 2024 · 1 comment
Assignees

Comments

@rafaarcangel
Copy link

Describe the bug

From the previous version 1.0.0 to the new 2.0.0, there are a few new lines to set ClientSecrets values to null.
This new code shows an empty box when you try to see those secrets in the UI

To Reproduce

1- Open backoffice
2- Go to client section > Manage secrets
3- Click on any secret
You will see an empty box
image

Relevant parts of the log file

The code that was changed is on ClientService.cs:

  • GetClientSecretsAsync
  • GetClientSecretAsync
clientSecretsDto.ClientSecrets.ForEach(delegate (ClientSecretDto x)
{
    x.Value = null;
});

Discussion reference: #1058

@skoruba
Copy link
Owner

skoruba commented May 23, 2024

I removed it very long time ago, because it was not recommended to be able to see this value there. it is from security reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants