Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No meaningful error messages for violations in sh:or statemanet #306

Open
sroertgen opened this issue May 23, 2024 · 1 comment
Open

No meaningful error messages for violations in sh:or statemanet #306

sroertgen opened this issue May 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sroertgen
Copy link
Contributor

          Thanks for reporting and fixing @thomschke!

@acka47

I stumbled across this by accident as well yesterday and think it has something to do with #284

We now have sh:or statements in our shacl graph for testing the presence of dct:title, skos:prefLabel and dc:title. The same for the description attributes.
The library we are using for doing the shacl validation can handle the validation, but does not give good errors if something goes wrong in these sh:or statements therefore the null statement which you and @thomschke encountered.

This is unfortunate since you also don't get meaningful error messages if one of these attributes is missing. The lib is not returning the correct path to identify the node where an error occured.

The fix provided by @thomschke will help to run vocabs through the pipeline if just a warning occured, but we are getting unhelpful error messages for violations, e.g.

-----------Violation--------------
 Message:  []
 Path:  undefined
 Node, where the error occured:  https://hof-halle-wittenberg.github.io/type/
 Severity of error:  http://www.w3.org/ns/shacl#Violation

(a description is missing in this vocab, but you don't get a good hint from the shacl validation)

Originally posted by @sroertgen in #305 (comment)

@sroertgen sroertgen added the bug Something isn't working label May 23, 2024
@acka47
Copy link
Member

acka47 commented Jun 10, 2024

a description is missing in this vocab, but you don't get a good hint from the shacl validation

Can this really be the source of the error? AFAICS, description is not mandatory, see https://github.com/skohub-io/skohub-shapes/blob/03905674a22a978288b56ca6709c604d0f7512a0/skohub.shacl.ttl#L62-L81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants