Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack Error Schema Construction Fix #176

Closed
dchoi127 opened this issue Mar 30, 2022 · 5 comments
Closed

Webpack Error Schema Construction Fix #176

dchoi127 opened this issue Mar 30, 2022 · 5 comments
Assignees

Comments

@dchoi127
Copy link

dchoi127 commented Mar 30, 2022

Screen Shot 2022-03-29 at 9 03 36 AM

When running "npm run build" this error would occur, terminating the schema construction. After a bit of tampering, I managed to find a solution by changing a line in the src/common.js file.

To recreate the issue, download the helminths.ttl file here: https://github.com/dchoi127/skohub-vocabs/blob/master/data/helminths.ttl

To resolve the issue, look here: dchoi127@0edaede

With my limited understanding of this issue, I believe this has to do with the localized array not existing for "helminths". This becomes clear when viewing the webpage after running "npm run develop". All the pages appear to work except [lod.nal.usda.gov/nalt-helminths.en.html] which triggers an unhandled runtime error. I believe it's due to the fact that "helminths" is treated as a concept although the localized array does not exist. The changes I implemented adds an additional null check to ensure localized cannot be null. With these changes, the webpage now builds with no errors. Are there any foreseeable problems with the changes to src/common.js?

@acka47
Copy link
Member

acka47 commented Mar 31, 2022

Hi @dchoi127, thanks for your report. The problem is that SkoHub currently expects the name fo a ConceptScheme to be provided with dct:title not skos:prefLabel. Copying the file into my test repo and adjusting this (acka47/testing-skohub-vocabs@7103825) made the build run, see https://skohub.io/acka47/hcrt/heads/master/lod.nal.usda.gov/nalt-helminths.en.html.

(We still have an issue open to enable an easy check whether a vocab is "SkoHub-ready", see #91 .)

@tombaker
Copy link

Hi @acka47 I provided the ConceptScheme with a dcterms:title alongside the existing rdfs:label (not skos:prefLabel) and it built correctly.

Is there a list of criteria (if only bullet points) in the code or documentation for "SkoHub-ready" concept schemes?

@acka47
Copy link
Member

acka47 commented Mar 31, 2022

Is there a list of criteria (if only bullet points) in the code or documentation for "SkoHub-ready" concept schemes?

Unfortunately, not. It's currently best to take orientation from examples. I collected some for the SkoHub booth at SWIB21: https://pad.gwdg.de/s/skohub-booth-at-swib21#Example-Vocabs

I know, we have to work on the documentation and I will try to address this in the course of this year. (A related issue is #174 .)

@acka47
Copy link
Member

acka47 commented Apr 1, 2022

@dchoi127 Please close the issue if your problem is resolved.

@dchoi127 dchoi127 closed this as completed Apr 1, 2022
@dchoi127
Copy link
Author

dchoi127 commented Apr 6, 2022

Problem was resolved. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants