Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librain_draw_finish() vs. librain_draw_finish_all() #20

Open
retostockli opened this issue Feb 26, 2020 · 1 comment
Open

librain_draw_finish() vs. librain_draw_finish_all() #20

retostockli opened this issue Feb 26, 2020 · 1 comment

Comments

@retostockli
Copy link

librain declares these two functions:
librain_draw_finish_all()
librain_draw_prepare_all()

But the plugin uses:
librain_draw_finish_all()
librain_draw_prepare_all()

This yields to a build error for the plugin:
../plugin.c: In function ‘draw_rain_effects’:
../plugin.c:559:2: error: implicit declaration of function ‘librain_draw_prepare’; did you mean ‘librain_draw_prepare_eye’? [-Werror=implicit-function-declaration]
librain_draw_prepare(B_TRUE);
^~~~~~~~~~~~~~~~~~~~
librain_draw_prepare_eye
../plugin.c:565:2: error: implicit declaration of function ‘librain_draw_finish’; did you mean ‘librain_draw_finish_all’? [-Werror=implicit-function-declaration]
librain_draw_finish();
^~~~~~~~~~~~~~~~~~~
librain_draw_finish_all
cc1: all warnings being treated as errors

Question: can I exchange the plugin functions with the _all() functions of the librain code?
Reto

@kukel
Copy link

kukel commented Sep 3, 2020

I changed these too, since if I don't (remove -Werror=...) I get errors starting the plugin in x-plane.
When I changed them, I got to a librain plugin that actually started in x-plane-11.50rc3 and with https://forums.x-plane.org/index.php?/files/file/50106-default-c172-librain-integration/ it even logs things (when the datarefs are set to verbose) In vulkan I see 0-1 fps loss (rounded down) in opengl 2-4. But....

I don't see anything on the screen/glass. Like there is no rain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants