remove dead code

skip-mev · Dec 26, 2023 · 5ed78b9 · 5ed78b9
1 parent 4c8aba2
commit 5ed78b9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/components/SwapWidget/SwapWidget.tsx b/src/components/SwapWidget/SwapWidget.tsx
@@ -23,7 +23,7 @@ import TransactionDialog from "../TransactionDialog";
 import { UsdDiff } from "../UsdValue";
 import { useWalletModal, WalletModal } from "../WalletModal";
 import { SwapDetails } from "./SwapDetails";
-import { useSwapWidget } from "./useSwapWidget";
+import { PRICE_IMPACT_THRESHOLD, useSwapWidget } from "./useSwapWidget";
 
 export const SwapWidget: FC = () => {
   const { openWalletModal } = useWalletModal();
@@ -265,7 +265,10 @@ export const SwapWidget: FC = () => {
                 route={route}
                 transactionCount={numberOfTransactions}
                 insufficientBalance={insufficientBalance}
-                priceImpactThresholdReached={priceImpactThresholdReached}
+                shouldShowPriceImpactWarning={
+                  priceImpactThresholdReached ||
+                  Math.abs(usdDiffPercent * 100) > PRICE_IMPACT_THRESHOLD
+                }
               />
               {insufficientBalance && (
                 <p className="text-center font-semibold text-sm text-red-500">

diff --git a/src/components/TransactionDialog/index.tsx b/src/components/TransactionDialog/index.tsx
@@ -13,15 +13,15 @@ interface Props {
   route?: RouteResponse;
   transactionCount: number;
   insufficientBalance?: boolean;
-  priceImpactThresholdReached?: boolean;
+  shouldShowPriceImpactWarning?: boolean;
 }
 
 const TransactionDialog: FC<Props> = ({
   isLoading,
   route,
   insufficientBalance,
   transactionCount,
-  priceImpactThresholdReached,
+  shouldShowPriceImpactWarning,
 }) => {
   const [hasDisplayedWarning, setHasDisplayedWarning] = useState(false);
   const [isOpen, setIsOpen] = useState(false);
@@ -38,7 +38,7 @@ const TransactionDialog: FC<Props> = ({
       return;
     }
 
-    if (priceImpactThresholdReached) {
+    if (shouldShowPriceImpactWarning) {
       control.open();
       setHasDisplayedWarning(true);
     }
@@ -47,7 +47,7 @@ const TransactionDialog: FC<Props> = ({
     setHasDisplayedWarning,
     isOpen,
     hasDisplayedWarning,
-    priceImpactThresholdReached,
+    shouldShowPriceImpactWarning,
   ]);
 
   return (