Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavTileProps.id is typed as optional, but is required #3085

Open
Mettwasser opened this issue Jan 8, 2025 · 1 comment
Open

NavTileProps.id is typed as optional, but is required #3085

Mettwasser opened this issue Jan 8, 2025 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Mettwasser
Copy link

Current Behavior

Using a Navigation.Tile component without an id is allowed by the type settings

Expected Behavior

Using a Navigation.Tile component enforces the id property to be set

Steps To Reproduce

<Navigation.Rail expanded background="bg-transparent">
    {#snippet tiles()}
          <Navigation.Tile
              labelExpanded="Hello there!"
          >
              <SomeIcon />
          </Navigation.Tile>
    {/snippet}
</Navigation.Rail>

Link to Reproduction / Stackblitz

No response

More Information

https://github.com/skeletonlabs/skeleton/blob/next/packages/skeleton-svelte/src/lib/components/Navigation/types.ts#L102

@Mettwasser Mettwasser added the bug Something isn't working label Jan 8, 2025
@endigo9740 endigo9740 added this to the v3.0 (Next) milestone Jan 8, 2025
@phamduylong
Copy link
Contributor

I'll throw a quick PR for this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants