Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should honor timezone information on requests and events #67

Open
roccoblues opened this issue Oct 27, 2017 · 3 comments
Open

Should honor timezone information on requests and events #67

roccoblues opened this issue Oct 27, 2017 · 3 comments

Comments

@roccoblues
Copy link

During a migration I had the (unfortunate) situation that some logjam agents where sending requests and events in UTC time and some in CET. (See also: skaes/logjam_agent#32).

It looks like the data is stored with the timezone information in the logjam database but the view doesn't handle it correctly.

Ideally logjam would adjust all times to the timezone configured for the logjam app (Rails.application.config.time_zone) and also adjust the graphs to it.

@skaes
Copy link
Owner

skaes commented Oct 30, 2017

Actually it is the logjam-importer which needs to be changed. It would need to convert incoming timestamps in all sorts of places to the desired timezone.

BTW: calling Rails.application.config.time_zone gives "UTC", even though running date on the console returns "Mon Oct 30 11:44:29 CET 2017"

@roccoblues
Copy link
Author

That's because Rails.application.config.time_zone defaults to UTC.

What I mean is that you should store all data in UTC (or with timezone information) in the database an then convert it for the view layer to Rails.application.config.time_zone. That way the user could choose the correct display timezone for his location.

But I guess that will be hard to do because you store daily databases.

@roccoblues
Copy link
Author

I know it's complicated and (at least for me) currently not required but as soon as you have servers with different timezone settings logjam will get confused. So don't let XING setup anything in the US. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants