-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown Message Types #58
Comments
Match ID: 1782181262 tick 57378, synthetic true, had 0 messages |
uploaded a new snapshot, which has all those... |
unknown embedded message of kind SOURCE2/510. Please report this in the correspo |
new snapshot uploaded |
What type of messages are these things? unknown embedded message of kind SOURCE2/62. Please report this in the correspon |
My guess is that @spheenik tried to remove as many of the messages from the generated Java classes as possible to reduce code size and speed up compile times. |
@howardchung: correct. @Decoud: |
@spheenik latest protobufs are always available at https://github.com/SteamDatabase/GameTracking/tree/master/Protobufs/dota |
+1 for GameTracking :) |
@manveru: thx! So, their netmessages say that it's CSVCMsg_HLTVStatus. I'll release a new protobuf snapshot tonight... |
new snapshot uploading as I type... |
SOURCE2/554 |
I think this is the new CombatLogDataHLTV. @spheenik added support for it last night, try updating your snapshot? |
Works fine, my bad. Should have checked for the update first. Will have to take a closer look at some of those combat log changes. |
kind 534 or 544 file name: frankfurt_major\1856290165_1750727379.dem file name: frankfurt_major\1858282173_1016472045.dem file name: frankfurt_major\1859146913_1174254792.dem file name: frankfurt_major\1860271085_922706473.dem file name: frankfurt_major\1861004655_314559210.dem file name: frankfurt_major\1861405896_2145933448.dem file name: frankfurt_major\1861422181_1394172680.dem |
Hi, thx for reporting! Deployed a new snapshot of clarity protobuf that has 534, The 544 is the new combatlog - I already included it a week ago. So it seems your snapshots are not up to date. |
Bullshit - 544 was new too - added. |
According to proto definition appears to be some kind of match metadata. Type is bytes so it's probably binary encoded in some way. |
I have a fix, but I cannot test it. |
Thx, will push a fix tonight. |
Fix is out. |
unknown embedded message of kind SOURCE2/558. Please report this in the corresponding issue: #58 (lower priority, I don't think this crashes the parser) |
I also got the same error as @howardchung
It seemed to have ran alright, no errors, though it does seem like it took longer to complete. |
added 558 (S2DotaGcCommon.CMsgDOTAMatch) which contains a lot of detailed information about the match. |
Can you help me with
|
added those 2 with this commit and pushed a new snapshot. |
I've been getting crashes lately with this code: unknown top level message of kind SOURCE2/1171. Please report this in the corresponding issue: #58
|
So you have to find the definition somewhere, (but where?) and update clarity-protobuf. I see that the repository has not been updated for 2 years, how is that possible? I see that this issue thread is quite active... Does it have to do with Maven Central? Like, clarity-protobuf being updated on Maven and not on GitHub? Can I help keeping clarity-protobuf up to date? |
There is a project on Github that extracts the protobuf definitions from the game regularly. https://github.com/SteamDatabase/GameTracking-Dota2 My approach is not to simply copy their definitions completely, since many of them are not needed for parsing demos, and sometimes they remove fields also, and I keep those fields in my definitions, since I want older replays to also be able to be read. It's true I didn't update for a long time, and should do so. But since the "core definitions" do not change, and there are mostly new UserMessages that will not be of interest for replay parsing anyway, I just figured it's priority B. |
I see, your approach has some careful steps to take. I propose you and/or I could make a page in the wiki on this repository (or clarity-protobufs) in GitHub and explain the steps. So if I or someone else who wanted to help keeping clarity-protobufs updated, could follow those steps and produce pull requests. How does it sound to you?
I followed your advice from time ago and started from clarity-examples and clarity-analyzer to be able to understand how to parse game events. Until I learn to do it, I wanted to use Clarity Analyzer to read through a replay quickly, to understand what variables I can parse with clarity. But these unknown message types make Analyzer crash. The next best thing is to use clarity-examples to dump the entire replay, which is not great for a beginner like me, but I make do with what I have. I'd be glad to help in the little free time I have. |
Unknown message ids should not make analyzer crash. The crash is most surely related to something else. |
Ah, sorry. I did not understand it. That's what you meant when you said the warning and the exception are not related to each other. Can I help with the crash as well? Should I open a new issue for the crash to separate it from this thread? |
The analyzer crash is most certainly because it uses an old version of clarity. |
Oh thank you, it was that... it works now. Let me know if I can help with the other stuff we talked about, glad if I can. |
Detailing the above details here: faq I too am experiencing the above mentioned issue:
Using git repo: with replay ID: Let me know if I misunderstood anything 🙇 |
Thank you for starting the wiki! I did not know if we were allowed to do it. |
New protobufs have been released. Added My testing capability was limited, since downloading replays through the client seems buggy atm. (Opendota also does not work). Regarding the Wiki Thing: |
Oh, and, the protobufs contain several extra combatlog properties. If you want to use them, I released clarity 2.7.6. Pushed both artifacts to central five minutes ago, so might be an hour or so before you see them. |
@spheenik Please do! I'll follow your lead on the docs. Thanks spheenik! |
also |
Not sure how to be more helpful, but I got a I was trying to parse the first map of this game https://www.hltv.org/matches/2370928/liquid-vs-faze-iem-chengdu-2024 |
unknown top level message of kind CSGO_S2/16. Please report this in the corresponding issue: #58 |
Thank you guys, |
|
Got an error parsing
|
Thanks for reporting, as long as the parsing process didn't crash, it's fine. |
Hey Martin @spheenik! When you do plan to do it- Would it be possible for you to record your process? I'd like to learn and document the process in the FAQ so others can potentially contribute in the protobuf parsing. You don't need to explain everything step by step- just dropping specific keywords will be enough for me to do my own research to be able to do it myself. If this is inconvenient to do- no worries. I just want to express my gratitude for your work! Thank you! |
got the same error, but the parser crashes. I'm just trying to seek to "getLastTick" in order to get scoreboard |
CSGO_S2/76, CSGO_S2/141 and CSGO_S2/154 have been added in |
@ndorigatti I just tested your replay, and it does not crash here in |
Yeah it was not in that furia replay, was one of mine... I will try again, but don't know how to share that 300mb replay |
@ndorigatti I have a hunch that self recorded replays do not properly encode the last tick. |
Dota 2. Match ID: 7888568761 I get the following message: Clarity seems to be up to date: api("com.skadistats:clarity:3.1.1") |
@thurd fixed in |
2024-10-17T23:49:17.997-07:00 WARN 38708 --- [ clarity-runner] clarity.runner : unknown embedded message of kind DEADLOCK/353. Please report this in the corresponding issue: #58 |
Thank you for reporting an unknown message type.
Please note: In case clarity detects an unknown message, it reports this with the warning, but will be able to skip over the message and successfully parse the replay. This means that if you have an exception, there is another problem, and I suggest you open a new issue.
The text was updated successfully, but these errors were encountered: