N-EVENT scripts and classes have SCU and SCP labels reverse of nominal usage

[sjswerdloff]

N-EVENT-REPORT are typically generated in what is an SCP for other purposes (to which the events refer to).
While the transmission of an N-EVENT-REPORT from the producer to the consumer requires either an association request to be created (by what is otherwise an SCP) or application of role reversal, the producer of the N-EVENT-REPORT is still referred to as an SCP in the DICOM Standard.

suggest renaming from neventscu to nevent_sender, nevent_producer, or nevent_publisher
and renaming neventscp to nevent_receiver, nevent_consumer, or nevent_subscriber respectively (sender/receiver, producer/consumer, or publisher/subscriber).

It is possible for a receiver/consumer to not have subscribed for itself (it received the subscription at the request of a different AE).
While the terminology for publish/subscriber is common in Event Driven Architecture (e.g. see: https://solace.com/what-is-an-event-broker/ ), the fact that a consumer of an event may not have subscribed itself motivates away from using publisher/subscriber. Further, if one were to create a broker, it would not itself have been the producer of an event, but it would act as a sender of an event, and similarly it would not be an end consumer of an event, but it would receive it.