From f093282a0fa69110608dc85a9eb0663801d764f1 Mon Sep 17 00:00:00 2001
From: Stuart Longland <me@vk4msl.com>
Date: Sun, 26 May 2024 20:56:38 +1000
Subject: [PATCH] kiss unit tests: Check frame queue handling

---
 tests/test_kiss/test_base.py | 63 +++++++++++++++++++++++++++++++++++-
 1 file changed, 62 insertions(+), 1 deletion(-)

diff --git a/tests/test_kiss/test_base.py b/tests/test_kiss/test_base.py
index 5f70f4a..2d113ff 100644
--- a/tests/test_kiss/test_base.py
+++ b/tests/test_kiss/test_base.py
@@ -11,7 +11,7 @@
     KISSPort,
 )
 from ..loop import DummyLoop
-from asyncio import BaseEventLoop
+from asyncio import BaseEventLoop, Future
 
 
 class DummyKISSDevice(BaseKISSDevice):
@@ -467,6 +467,67 @@ def _on_fail(**kwargs):
     assert failures == []
 
 
+def test_send_data_emptybuffer():
+    """
+    Test that _send_data will pick the next frame off the transmit queue if
+    it has nothing to send in the buffer.
+    """
+    loop = DummyLoop()
+    kissdev = DummyKISSDevice(loop=loop)
+    my_future = Future()
+    assert bytes(kissdev._tx_buffer) == b""
+
+    kissdev._tx_queue = [(b"test output data", my_future)]
+
+    failures = []
+
+    def _on_fail(**kwargs):
+        failures.append(kwargs)
+
+    kissdev.failed.connect(_on_fail)
+
+    # Send the data out.
+    kissdev._send_data()
+
+    # We should now see this was "sent" and now in 'transmitted'
+    assert bytes(kissdev.transmitted) == b"\xc0test output data\xc0"
+
+    # my_future should be the current transmit future
+    assert kissdev._tx_future is my_future
+
+    # That should be the lot
+    assert len(loop.calls) == 0
+
+    # There should be no failures
+    assert failures == []
+
+
+def test_send_data_emptybuffer_emptyqueue():
+    """
+    Test that _send_data does nothing if all queues are empty.
+    """
+    loop = DummyLoop()
+    kissdev = DummyKISSDevice(loop=loop)
+    assert bytes(kissdev._tx_buffer) == b""
+    assert kissdev._tx_queue == []
+
+    failures = []
+
+    def _on_fail(**kwargs):
+        failures.append(kwargs)
+
+    kissdev.failed.connect(_on_fail)
+
+    # Send the data out.
+    kissdev._send_data()
+
+    # That should be the lot
+    assert len(loop.calls) == 0
+
+    # There should be no failures
+    assert failures == []
+
+
 def test_send_data_fail():
     """
     Test that _send_data puts device in failed state if send fails.