From a402e44bf2d5ff2c86addcc2324a3bbfbc41213f Mon Sep 17 00:00:00 2001
From: Stuart Longland <me@vk4msl.com>
Date: Sat, 4 May 2024 20:35:31 +1000
Subject: [PATCH] kiss: Test transport shutdown

---
 aioax25/kiss.py                | 13 ++++++
 tests/test_kiss/test_serial.py | 82 ++++++++++++++++++++++++++++++++++
 2 files changed, 95 insertions(+)

diff --git a/aioax25/kiss.py b/aioax25/kiss.py
index 85b7e47..72e134f 100644
--- a/aioax25/kiss.py
+++ b/aioax25/kiss.py
@@ -502,6 +502,19 @@ def _on_close(self, exc=None):
     def _send_raw_data(self, data):
         self._transport.write(data)
 
+    def reset(self):
+        super(BaseTransportDevice, self).reset()
+
+        try:
+            if self._transport:
+                self._transport.close()
+        except:
+            self._log.warning(
+                "Failed to close transport, ignoring!", exc_info=1
+            )
+
+        self._transport = None
+
 
 class SerialKISSDevice(BaseTransportDevice):
     """
diff --git a/tests/test_kiss/test_serial.py b/tests/test_kiss/test_serial.py
index 961e6c1..f49e163 100644
--- a/tests/test_kiss/test_serial.py
+++ b/tests/test_kiss/test_serial.py
@@ -300,3 +300,85 @@ async def test_send_raw_data():
 
     kissdev._send_raw_data(b"a test frame")
     assert bytes(connection.port.tx_buffer) == b"a test frame"
+
+
+def test_reset_no_transport():
+    """
+    Test reset handles the "no transport" case
+    """
+    loop = get_event_loop()
+    kissdev = TestDevice(device="/dev/ttyS0", baudrate=9600, loop=loop)
+    assert kissdev._transport is None
+
+    # Inject state
+    kissdev._state = kiss.KISSDeviceState.FAILED
+
+    # Reset
+    kissdev.reset()
+
+    assert kissdev.state == kiss.KISSDeviceState.CLOSED
+
+
+def test_reset_with_transport():
+    """
+    Test reset closes the transport if it exists
+    """
+    loop = get_event_loop()
+    kissdev = TestDevice(device="/dev/ttyS0", baudrate=9600, loop=loop)
+
+    assert kissdev._transport is None
+
+    class MyTransport(object):
+        def __init__(self):
+            self.closed = False
+
+        def close(self):
+            assert not self.closed
+            self.closed = True
+
+    # Inject transport
+    transport = MyTransport()
+    kissdev._transport = transport
+
+    # Inject state
+    kissdev._state = kiss.KISSDeviceState.FAILED
+
+    # Reset
+    kissdev.reset()
+
+    assert kissdev.state == kiss.KISSDeviceState.CLOSED
+    assert kissdev._transport is None
+    assert transport.closed
+
+
+def test_reset_with_transport_err():
+    """
+    Test reset swallows close errors from the transport
+    """
+    loop = get_event_loop()
+    kissdev = TestDevice(device="/dev/ttyS0", baudrate=9600, loop=loop)
+
+    assert kissdev._transport is None
+
+    class MyTransport(object):
+        def __init__(self):
+            self.closed = False
+
+        def close(self):
+            assert not self.closed
+            self.closed = True
+            raise IOError("Whoopsie!")
+
+    # Inject transport
+    transport = MyTransport()
+    kissdev._transport = transport
+
+    # Inject state
+    kissdev._state = kiss.KISSDeviceState.FAILED
+
+    # Reset
+    kissdev.reset()
+
+    assert kissdev.state == kiss.KISSDeviceState.CLOSED
+    assert kissdev._transport is None
+    assert transport.closed