Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up inner loop #278

Open
gustavdelius opened this issue Jan 9, 2023 · 0 comments
Open

Speed up inner loop #278

gustavdelius opened this issue Jan 9, 2023 · 0 comments
Labels
core Issue relates to the mizer core enhancement New feature requests or suggestions for enhancement of existing features minor effort Resolving this issue will involve a minor effort

Comments

@gustavdelius
Copy link
Member

We can easily speed up the inner loop over size classes at

https://github.com/sizespectrum/mizer/blob/420fca74da0d31134415b9e71dbd2bb18ea76054/src/inner_project_loop.cpp#LL11-L13

by only running up the size class of the maximum size of the species. We only need to add a w_max_idx vector argument to inner_project_loop() and can then get rid of the no_w argument.
@gustavdelius gustavdelius added enhancement New feature requests or suggestions for enhancement of existing features core Issue relates to the mizer core minor effort Resolving this issue will involve a minor effort labels Jan 9, 2023
gustavdelius added a commit that referenced this issue Dec 1, 2023
@gustavdelius
Introducing w_max_idx which can speed up the inner loop, see #278.
a769cb3 
The savings are minimal however.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Issue relates to the mizer core enhancement New feature requests or suggestions for enhancement of existing features minor effort Resolving this issue will involve a minor effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gustavdelius